DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Myers, Charles" <Charles.Myers@spirent.com>
Cc: Yong Wang <yongwang@vmware.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU.
Date: Tue, 20 Aug 2019 21:43:06 -0700
Message-ID: <20190820214306.6ef7cd7f@hermes.lan> (raw)
In-Reply-To: <1566353778-14774-1-git-send-email-charles.myers@spirent.com>

On Wed, 21 Aug 2019 02:16:58 +0000
"Myers, Charles" <Charles.Myers@spirent.com> wrote:

>  
>  static int
> +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{
> +	if (dev->data->dev_started) {
> +		PMD_DRV_LOG(ERR, "Port %d must be stopped to configure MTU",
> +			    dev->data->port_id);
> +		return -EBUSY;
> +	}
> +
> +	return 0;
> +}
> +

Don't you need to reset the rx ring to change mtu on the fly?
At a minimum you need to communicate this value to host through the
shared driver page.


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  4:53 [dpdk-dev] [PATCH] " Myers, Charles
2019-08-20  4:06 ` [dpdk-dev] [PATCH v2] " Myers, Charles
2019-08-20 15:12   ` Stephen Hemminger
2019-09-03 20:10   ` Yong Wang
2019-08-21  2:16 ` [dpdk-dev] [PATCH v3] " Myers, Charles
2019-08-21  4:43   ` Stephen Hemminger [this message]
2019-08-21  5:19     ` Myers, Charles
2019-09-13 18:47   ` Ferruh Yigit
2019-09-13 18:59     ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820214306.6ef7cd7f@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=Charles.Myers@spirent.com \
    --cc=dev@dpdk.org \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox