From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E435C3A59E for ; Mon, 26 Aug 2019 09:21:44 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C7F4222CF8 for ; Mon, 26 Aug 2019 09:21:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7F4222CF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 838271BEFC; Mon, 26 Aug 2019 11:21:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8E81A1BEF5 for ; Mon, 26 Aug 2019 11:21:40 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 02:21:39 -0700 X-IronPort-AV: E=Sophos;i="5.64,431,1559545200"; d="scan'208";a="184899615" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 02:21:34 -0700 Date: Mon, 26 Aug 2019 10:21:31 +0100 From: Bruce Richardson To: "Wiles, Keith" Cc: David Marchand , dpdk dev community , "Burakov, Anatoly" , Hemant Agrawal , Sachin Saxena , "Yigit, Ferruh" , Stephen Hemminger , "Ma, Liang J" , "Mccarthy, Peter" , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , "Xu, Rosen" , "Zhang, Tianfei" , "Ananyev, Konstantin" , Honnappa Nagarahalli Message-ID: <20190826092131.GA1731@bricha3-MOBL.ger.corp.intel.com> References: <1565592813-5164-1-git-send-email-david.marchand@redhat.com> <9FC063DA-0039-4D1F-882C-57945F34D9A2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9FC063DA-0039-4D1F-882C-57945F34D9A2@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] remove unneeded eal header inclusion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 12, 2019 at 12:25:03PM +0100, Wiles, Keith wrote: > > > > On Aug 12, 2019, at 1:53 AM, David Marchand wrote: > > > > Restrict this header inclusion to its real users. > > > > Fixes: 028669bc9f0d ("eal: hide shared memory config") > > > > Signed-off-by: David Marchand > > The only thing I would suggest is to add the name of the header file in the subject or body of the commit, as currently it is not obvious reading the commit title or body. > > Regards, > Keith +1