From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6A0C43331 for ; Thu, 5 Sep 2019 17:13:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E64D420828 for ; Thu, 5 Sep 2019 17:13:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="g/guvQr3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E64D420828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 427AA1F075; Thu, 5 Sep 2019 19:13:23 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 0CB111F03B for ; Thu, 5 Sep 2019 19:13:21 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id w10so1757810pgj.7 for ; Thu, 05 Sep 2019 10:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yvrfF/RrH3Er/OPL1ZIG0dhQGmg7JbITu9Iz9sH2wUU=; b=g/guvQr3b6nkA70nnoJLKQE7cN3UZAPg/6sTlxvb14EFeAdam2vEILxuEppCN1Qe3U vw2/bGgIfhRzLLOoBcV56nlPQ7gNF4m7stufl/L2NYfH8nROFjrB/IUROU9QhRscN5LR Jnb5U+vXX2KIjwSXRREOvobJjrakR0T65sS5gpecQN7RJBD58FO+JH5bwPTD4f2K5wYR 1ilyMs1iTL9klo0GL8cVSaG3VM/VZTqPn6A7cUVp30IVjMCgHcGeUi0Zc8BajrMnqOMS GU/vlfQMW14z79PBUrjstQBMnOMqxPQ4LFhv5dNh3sQw8OthywQW3Qyfw3ZKWlILR/0D qHjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yvrfF/RrH3Er/OPL1ZIG0dhQGmg7JbITu9Iz9sH2wUU=; b=T/gklHoiKe3cM8If72TgEt22m40bzR4i+4ZTwMeOzNivanHZXGHAsrpiMMAkFCce4V EjGEb01IAAjxJF4ZeAf0TA8bZ9IZLzTOBzqsESe6Y+Ja4hJPrYwg4hzAf7ypv3PSoztK +GwKxszGKnU/TEnboG3DvTW6W0KfQFIcJGIQIuUCc2k9jHhAGPyYVTD7tIRMAduy1X3y bOaYE5uoQsv317nVBkK7TJprstO2HJF02y+gXHTc+AFYZqsRMcDD2u6pMUTyUbwftChc 8kj8YaTBtSP66NZc3nVRem3i8sWyj/Cl1sDq1Ru6sSL3HBVR6yFMqfl71BQMwOcLVrfG re8w== X-Gm-Message-State: APjAAAU+ivF1IEEUFEXViquo3xShCm3xDsxOALp8GD2u/aCtv23fIwgw y5CL344mdFSbrztDGhKAXfoTv/VBQbU= X-Google-Smtp-Source: APXvYqwMTc+iAsH+Eu1BHnOnuhGZEilBFywtUgK6aiZDelENk3c5DJ3Pad6V3QeLHODOY7fNeTYpcw== X-Received: by 2002:a63:188:: with SMTP id 130mr4117803pgb.231.1567703600998; Thu, 05 Sep 2019 10:13:20 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b18sm3600459pfi.160.2019.09.05.10.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 10:13:20 -0700 (PDT) Date: Thu, 5 Sep 2019 10:13:19 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Gaetan Rivet , , Ivan Ilchenko Message-ID: <20190905101319.11a374a6@hermes.lan> In-Reply-To: References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1567699852-31693-3-git-send-email-arybchenko@solarflare.com> <20190905094013.6038f374@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 5 Sep 2019 19:49:09 +0300 Andrew Rybchenko wrote: > On 9/5/19 7:40 PM, Stephen Hemminger wrote: > > On Thu, 5 Sep 2019 17:10:40 +0100 > > Andrew Rybchenko wrote: > > > >> From: Ivan Ilchenko > >> > >> rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > >> value was changed from void to int, so this patch modify usage > >> of these functions across net/failsafe according to new return type. > >> > >> Try to keep promiscuous mode consistent across all active > >> devices in the case of failure. > >> > >> Signed-off-by: Ivan Ilchenko > >> Signed-off-by: Andrew Rybchenko > > In reality, failsafe's promiscious mode is actually a lie. > > The only common use case of failsafe is on Azure/Hyper-V and in a guest > > setting promiscuous is not allowed. That is why there is no promiscuous > > setting in netvsc PMD. I forgot Hyper-V is not same as Azure. It will always fail on Azure, but will work be allowed on Hyper-V (if enabled on host).