From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823FCC3A5A5 for ; Thu, 5 Sep 2019 12:18:23 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 398B121883 for ; Thu, 5 Sep 2019 12:18:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 398B121883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECBF51EFC7; Thu, 5 Sep 2019 14:18:21 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 79D3C1EFB3; Thu, 5 Sep 2019 14:18:19 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 05:18:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="383835964" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by fmsmga006.fm.intel.com with ESMTP; 05 Sep 2019 05:18:18 -0700 Date: Thu, 5 Sep 2019 20:16:19 +0800 From: Ye Xiaolong To: "lunyuan.cui" Cc: dev@dpdk.org, Wenzhuo Lu , stable@dpdk.org Message-ID: <20190905121619.GG70700@intel.com> References: <20190905032240.23239-1-lunyuanx.cui@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905032240.23239-1-lunyuanx.cui@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix multi-queue Rx interrupt for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/05, lunyuan.cui wrote: >The original issue was that the last queue could not >be mapped to the interrupt vector, so the last queue >could not receive the package in the interrupt mode. >This patch fix the issue. s/fix/fixes > >Fixes: d6bde6b5ea ("net/avf: enable Rx interrupt") The convention is to have the 12 characters of commit SHA in Fixes tag. >Cc: stable@dpdk.org > >Signed-off-by: lunyuan.cui Signature format should be Signed-off-by: Lunyuan Cui Thanks, Xiaolong >--- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c >index 8f3907378..6559bfa1f 100644 >--- a/drivers/net/iavf/iavf_ethdev.c >+++ b/drivers/net/iavf/iavf_ethdev.c >@@ -360,7 +360,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev, > for (i = 0; i < dev->data->nb_rx_queues; i++) { > vf->rxq_map[vec] |= 1 << i; > intr_handle->intr_vec[i] = vec++; >- if (vec >= vf->nb_msix) >+ if (vec > vf->nb_msix) > vec = IAVF_RX_VEC_START; > } > PMD_DRV_LOG(DEBUG, >-- >2.17.1 >