From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F022DCA9EA0 for ; Fri, 18 Oct 2019 09:22:25 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6C5E1222C3 for ; Fri, 18 Oct 2019 09:22:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=6wind.com header.i=@6wind.com header.b="OImCCTDr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C5E1222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=6wind.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4A831C192; Fri, 18 Oct 2019 11:22:23 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 413261C13A for ; Fri, 18 Oct 2019 11:22:22 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id f22so5362697wmc.2 for ; Fri, 18 Oct 2019 02:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZBcrlaFH6ixeZ519EosNDZdLM9RJCVPE68nXVXmXR1s=; b=OImCCTDrtu5pNjRFN8+4oNxvbOAYjOCvYDIRmph4ZkXYSPE+7vuev+KHLHLLJOwQdT F7AYnCCQTe15XqzAmxQ2g2ikK29N2ttY3PuExVjLOEbaXJMFZsBYi2k9fHmjxEL3EbMz V8AgMgvdesUPwZr68cqrRr5f2Hpwr3rbm05ZsW4Umkmj9hPL1xtbk/DV/ocTAygNviYK 6L3+9bOlPU8M1F0fbIiLEy9wYSYG3ov4dKlU4enO8oqbRqqvhxIoSMDK8m+gKwcF/Rvq pYqxlcoq1tIL21r0n80h0gmC5umdaNbo97PAAOp5842pJT0pepZDwLxeZOsh/7Oj8gmv XMew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZBcrlaFH6ixeZ519EosNDZdLM9RJCVPE68nXVXmXR1s=; b=acB0Ub2VqgzXBZ7crPz63Loq5pKVD4f3+qcyJLJhkPXTna6kuRKFWFbzsrFDOqy0wv y4t55ybO1ghozcBH745noSaVmKbVsLvBblBWh8VCKBndu0iKcjhyPSasQlCodneXlCRe phj3XBu1DkwBGCvZyI99hc8N/N3Rd8jPbJ7NWxu79+s9Ka3SCO6k8SlAYWlP3L1XqfUz HP+y6kZcn8H/vQc1Tw4ceVx479+DAPvZifUl92HfeYUdhBIay0y2+qdMkMkNOCjKQOqw oRi4VdnDeqvhjyUzJXqdoUNhVJK8QhyhtfJ5FHtynHnkDvTdzXZ79efO/sqI9YI8znTH lG5Q== X-Gm-Message-State: APjAAAVZ2MGV2OpZSZaNRPSAwOHhn71xjFEVD2+JroypavBkc3wcSPB3 nWocKJpVxM9Oqe/xyYSYw3jbNg== X-Google-Smtp-Source: APXvYqwJNA4u6qSQjk1yI13NnA2pXJMNFoxmAOzl20s4ryLhoJsPau7q0NYQVlJWJxS3ZVy8QIkx4A== X-Received: by 2002:a7b:c95a:: with SMTP id i26mr6696330wml.120.1571390541565; Fri, 18 Oct 2019 02:22:21 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id t13sm6100868wra.70.2019.10.18.02.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:22:20 -0700 (PDT) Date: Fri, 18 Oct 2019 11:22:19 +0200 From: Olivier Matz To: Viacheslav Ovsiienko Cc: dev@dpdk.org, matan@mellanox.com, rasland@mellanox.com, thomas@monjalon.net, Yongseok Koh Message-ID: <20191018092219.z5yoldgnicltypjr@platinum> References: <20190704232122.19477-1-yskoh@mellanox.com> <1570723359-24650-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570723359-24650-1-git-send-email-viacheslavo@mellanox.com> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Viacheslav, Few comments on the dynamic mbuf part below. On Thu, Oct 10, 2019 at 04:02:39PM +0000, Viacheslav Ovsiienko wrote: > Currently, metadata can be set on egress path via mbuf tx_metadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. > > This patch extends the metadata feature usability. > > 1) RTE_FLOW_ACTION_TYPE_SET_META > > When supporting multiple tables, Tx metadata can also be set by a rule and > matched by another rule. This new action allows metadata to be set as a > result of flow match. > > 2) Metadata on ingress > > There's also need to support metadata on ingress. Metadata can be set by > SET_META action and matched by META item like Tx. The final value set by > the action will be delivered to application via metadata dynamic field of > mbuf which can be accessed by RTE_FLOW_DYNF_METADATA(). > PKT_RX_DYNF_METADATA flag will be set along with the data. > > The mbuf dynamic field must be registered by calling > rte_flow_dynf_metadata_register() prior to use SET_META action. > > The availability of dynamic mbuf metadata field can be checked > with rte_flow_dynf_metadata_avail() routine. > > For loopback/hairpin packet, metadata set on Rx/Tx may or may not be > propagated to the other path depending on hardware capability. > > Signed-off-by: Yongseok Koh > Signed-off-by: Viacheslav Ovsiienko > --- > > This patch uses dynamic mbuf field and must be applied after: > http://patches.dpdk.org/patch/59343/ > "mbuf: support dynamic fields and flags" > > v2: - rebased > - relies on dynamic mbuf field feature > > v1: http://patches.dpdk.org/patch/56103/ > > rfc: http://patches.dpdk.org/patch/54270/ > > app/test-pmd/cmdline_flow.c | 57 ++++++++++++++++++++- > app/test-pmd/util.c | 5 ++ > doc/guides/prog_guide/rte_flow.rst | 57 +++++++++++++++++++++ > doc/guides/rel_notes/release_19_11.rst | 8 +++ > lib/librte_ethdev/rte_ethdev.h | 1 - > lib/librte_ethdev/rte_ethdev_version.map | 6 +++ > lib/librte_ethdev/rte_flow.c | 41 +++++++++++++++ > lib/librte_ethdev/rte_flow.h | 87 ++++++++++++++++++++++++++++++-- > lib/librte_mbuf/rte_mbuf_dyn.h | 8 +++ > 9 files changed, 265 insertions(+), 5 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index b26b8bf..078f256 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -305,6 +305,9 @@ enum index { > ACTION_DEC_TCP_ACK_VALUE, > ACTION_RAW_ENCAP, > ACTION_RAW_DECAP, > + ACTION_SET_META, > + ACTION_SET_META_DATA, > + ACTION_SET_META_MASK, > }; > > /** Maximum size for pattern in struct rte_flow_item_raw. */ > @@ -994,6 +997,7 @@ struct parse_action_priv { > ACTION_DEC_TCP_ACK, > ACTION_RAW_ENCAP, > ACTION_RAW_DECAP, > + ACTION_SET_META, > ZERO, > }; > > @@ -1180,6 +1184,13 @@ struct parse_action_priv { > ZERO, > }; > > +static const enum index action_set_meta[] = { > + ACTION_SET_META_DATA, > + ACTION_SET_META_MASK, > + ACTION_NEXT, > + ZERO, > +}; > + > static int parse_set_raw_encap_decap(struct context *, const struct token *, > const char *, unsigned int, > void *, unsigned int); > @@ -1238,6 +1249,10 @@ static int parse_vc_action_raw_encap(struct context *, > static int parse_vc_action_raw_decap(struct context *, > const struct token *, const char *, > unsigned int, void *, unsigned int); > +static int parse_vc_action_set_meta(struct context *ctx, > + const struct token *token, const char *str, > + unsigned int len, void *buf, > + unsigned int size); > static int parse_destroy(struct context *, const struct token *, > const char *, unsigned int, > void *, unsigned int); > @@ -3222,7 +3237,31 @@ static int comp_vc_action_rss_queue(struct context *, const struct token *, > .help = "set raw decap data", > .next = NEXT(next_item), > .call = parse_set_raw_encap_decap, > - } > + }, > + [ACTION_SET_META] = { > + .name = "set_meta", > + .help = "set metadata", > + .priv = PRIV_ACTION(SET_META, > + sizeof(struct rte_flow_action_set_meta)), > + .next = NEXT(action_set_meta), > + .call = parse_vc_action_set_meta, > + }, > + [ACTION_SET_META_DATA] = { > + .name = "data", > + .help = "metadata value", > + .next = NEXT(action_set_meta, NEXT_ENTRY(UNSIGNED)), > + .args = ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_set_meta, data)), > + .call = parse_vc_conf, > + }, > + [ACTION_SET_META_MASK] = { > + .name = "mask", > + .help = "mask for metadata value", > + .next = NEXT(action_set_meta, NEXT_ENTRY(UNSIGNED)), > + .args = ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_action_set_meta, mask)), > + .call = parse_vc_conf, > + }, > }; > > /** Remove and return last entry from argument stack. */ > @@ -4592,6 +4631,22 @@ static int comp_vc_action_rss_queue(struct context *, const struct token *, > return ret; > } > > +static int > +parse_vc_action_set_meta(struct context *ctx, const struct token *token, > + const char *str, unsigned int len, void *buf, > + unsigned int size) > +{ > + int ret; > + > + ret = parse_vc(ctx, token, str, len, buf, size); > + if (ret < 0) > + return ret; > + ret = rte_flow_dynf_metadata_register(); > + if (ret < 0) > + return -1; > + return len; > +} > + > /** Parse tokens for destroy command. */ > static int > parse_destroy(struct context *ctx, const struct token *token, > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c > index 1570270..39ff07b 100644 > --- a/app/test-pmd/util.c > +++ b/app/test-pmd/util.c > @@ -81,6 +81,11 @@ > mb->vlan_tci, mb->vlan_tci_outer); > else if (ol_flags & PKT_RX_VLAN) > printf(" - VLAN tci=0x%x", mb->vlan_tci); > + if (ol_flags & PKT_TX_METADATA) > + printf(" - Tx metadata: 0x%x", mb->tx_metadata); > + if (ol_flags & PKT_RX_DYNF_METADATA) > + printf(" - Rx metadata: 0x%x", > + *RTE_FLOW_DYNF_METADATA(mb)); > if (mb->packet_type) { > rte_get_ptype_name(mb->packet_type, buf, sizeof(buf)); > printf(" - hw ptype: %s", buf); > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index ff6fb11..45fc041 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -658,6 +658,32 @@ the physical device, with virtual groups in the PMD or not at all. > | ``mask`` | ``id`` | zeroed to match any value | > +----------+----------+---------------------------+ > > +Item: ``META`` > +^^^^^^^^^^^^^^^^^ > + > +Matches 32 bit metadata item set. > + > +On egress, metadata can be set either by mbuf metadata field with > +PKT_TX_METADATA flag or ``SET_META`` action. On ingress, ``SET_META`` > +action sets metadata for a packet and the metadata will be reported via > +``metadata`` dynamic field of ``rte_mbuf`` with PKT_RX_DYNF_METADATA flag. > + > +- Default ``mask`` matches the specified Rx metadata value. > + > +.. _table_rte_flow_item_meta: > + > +.. table:: META > + > + +----------+----------+---------------------------------------+ > + | Field | Subfield | Value | > + +==========+==========+=======================================+ > + | ``spec`` | ``data`` | 32 bit metadata value | > + +----------+----------+---------------------------------------+ > + | ``last`` | ``data`` | upper range value | > + +----------+----------+---------------------------------------+ > + | ``mask`` | ``data`` | bit-mask applies to "spec" and "last" | > + +----------+----------+---------------------------------------+ > + > Data matching item types > ~~~~~~~~~~~~~~~~~~~~~~~~ > > @@ -2415,6 +2441,37 @@ Value to decrease TCP acknowledgment number by is a big-endian 32 bit integer. > > Using this action on non-matching traffic will result in undefined behavior. > > +Action: ``SET_META`` > +^^^^^^^^^^^^^^^^^^^^^^^ > + > +Set metadata. Item ``META`` matches metadata. > + > +Metadata set by mbuf metadata field with PKT_TX_METADATA flag on egress will be > +overridden by this action. On ingress, the metadata will be carried by > +``metadata`` dynamic field of ``rte_mbuf`` which can be accessed by > +``RTE_FLOW_DYNF_METADATA()``. PKT_RX_DYNF_METADATA flag will be set along > +with the data. > + > +The mbuf dynamic field must be registered by calling > +``rte_flow_dynf_metadata_register()`` prior to use ``SET_META`` action. > + > +Altering partial bits is supported with ``mask``. For bits which have never been > +set, unpredictable value will be seen depending on driver implementation. For > +loopback/hairpin packet, metadata set on Rx/Tx may or may not be propagated to > +the other path depending on HW capability. > + > +.. _table_rte_flow_action_set_meta: > + > +.. table:: SET_META > + > + +----------+----------------------------+ > + | Field | Value | > + +==========+============================+ > + | ``data`` | 32 bit metadata value | > + +----------+----------------------------+ > + | ``mask`` | bit-mask applies to "data" | > + +----------+----------------------------+ > + > Negative types > ~~~~~~~~~~~~~~ > > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst > index 8921cfd..904746e 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -95,6 +95,14 @@ New Features > for specific offload features, where adding a static field or flag > in the mbuf is not justified. > > +* **Extended metadata support in rte_flow.** > + > + Flow metadata is extended to both Rx and Tx. > + > + * Tx metadata can also be set by SET_META action of rte_flow. > + * Rx metadata is delivered to host via a dynamic field of ``rte_mbuf`` with > + PKT_RX_DYNF_METADATA. > + > Removed Items > ------------- > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index d937fb4..9a6432c 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1013,7 +1013,6 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_KEEP_CRC 0x00010000 > #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 > #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 > - > #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ > DEV_RX_OFFLOAD_UDP_CKSUM | \ > DEV_RX_OFFLOAD_TCP_CKSUM) > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map > index 6df42a4..3d9cafc 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -283,4 +283,10 @@ EXPERIMENTAL { > > # added in 19.08 > rte_eth_read_clock; > + > + # added in 19.11 > + rte_flow_dynf_metadata_offs; > + rte_flow_dynf_metadata_flag; > + rte_flow_dynf_metadata_avail; > + rte_flow_dynf_metadata_register; > }; > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c > index cc03b15..9cbda75 100644 > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c > @@ -12,10 +12,18 @@ > #include > #include > #include > +#include > +#include > #include "rte_ethdev.h" > #include "rte_flow_driver.h" > #include "rte_flow.h" > > +/* Mbuf dynamic field name for metadata. */ > +int rte_flow_dynf_metadata_offs = -1; > + > +/* Mbuf dynamic field flag bit number for metadata. */ > +uint64_t rte_flow_dynf_metadata_mask; > + > /** > * Flow elements description tables. > */ > @@ -153,8 +161,41 @@ struct rte_flow_desc_data { > MK_FLOW_ACTION(DEC_TCP_SEQ, sizeof(rte_be32_t)), > MK_FLOW_ACTION(INC_TCP_ACK, sizeof(rte_be32_t)), > MK_FLOW_ACTION(DEC_TCP_ACK, sizeof(rte_be32_t)), > + MK_FLOW_ACTION(SET_META, sizeof(struct rte_flow_action_set_meta)), > }; > > +int > +rte_flow_dynf_metadata_register(void) > +{ > + int offset; > + int flag; > + > + static const struct rte_mbuf_dynfield desc_offs = { > + .name = MBUF_DYNF_METADATA_NAME, > + .size = MBUF_DYNF_METADATA_SIZE, > + .align = MBUF_DYNF_METADATA_ALIGN, > + .flags = MBUF_DYNF_METADATA_FLAGS, > + }; > + static const struct rte_mbuf_dynflag desc_flag = { > + .name = MBUF_DYNF_METADATA_NAME, > + }; I don't see think we need #defines. You can directly use the name, sizeof() and __alignof__() here. If the information is used externally, the structure shall be made global non-static. > + > + offset = rte_mbuf_dynfield_register(&desc_offs); > + if (offset < 0) > + goto error; > + flag = rte_mbuf_dynflag_register(&desc_flag); > + if (flag < 0) > + goto error; > + rte_flow_dynf_metadata_offs = offset; > + rte_flow_dynf_metadata_mask = (1ULL << flag); > + return 0; > + > +error: > + rte_flow_dynf_metadata_offs = -1; > + rte_flow_dynf_metadata_mask = 0ULL; > + return -rte_errno; > +} > + > static int > flow_err(uint16_t port_id, int ret, struct rte_flow_error *error) > { > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 391a44a..a27e619 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -27,6 +27,8 @@ > #include > #include > #include > +#include > +#include > > #ifdef __cplusplus > extern "C" { > @@ -417,7 +419,8 @@ enum rte_flow_item_type { > /** > * [META] > * > - * Matches a metadata value specified in mbuf metadata field. > + * Matches a metadata value. > + * > * See struct rte_flow_item_meta. > */ > RTE_FLOW_ITEM_TYPE_META, > @@ -1213,9 +1216,17 @@ struct rte_flow_item_icmp6_nd_opt_tla_eth { > #endif > > /** > - * RTE_FLOW_ITEM_TYPE_META. > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > * > - * Matches a specified metadata value. > + * RTE_FLOW_ITEM_TYPE_META > + * > + * Matches a specified metadata value. On egress, metadata can be set either by > + * mbuf tx_metadata field with PKT_TX_METADATA flag or > + * RTE_FLOW_ACTION_TYPE_SET_META. On ingress, RTE_FLOW_ACTION_TYPE_SET_META sets > + * metadata for a packet and the metadata will be reported via mbuf metadata > + * dynamic field with PKT_RX_DYNF_METADATA flag. The dynamic mbuf field must be > + * registered in advance by rte_flow_dynf_metadata_register(). > */ > struct rte_flow_item_meta { > rte_be32_t data; > @@ -1813,6 +1824,13 @@ enum rte_flow_action_type { > * undefined behavior. > */ > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK, > + > + /** > + * Set metadata on ingress or egress path. > + * > + * See struct rte_flow_action_set_meta. > + */ > + RTE_FLOW_ACTION_TYPE_SET_META, > }; > > /** > @@ -2300,6 +2318,43 @@ struct rte_flow_action_set_mac { > uint8_t mac_addr[RTE_ETHER_ADDR_LEN]; > }; > > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ACTION_TYPE_SET_META > + * > + * Set metadata. Metadata set by mbuf tx_metadata field with > + * PKT_TX_METADATA flag on egress will be overridden by this action. On > + * ingress, the metadata will be carried by mbuf metadata dynamic field > + * with PKT_RX_DYNF_METADATA flag if set. The dynamic mbuf field must be > + * registered in advance by rte_flow_dynf_metadata_register(). > + * > + * Altering partial bits is supported with mask. For bits which have never > + * been set, unpredictable value will be seen depending on driver > + * implementation. For loopback/hairpin packet, metadata set on Rx/Tx may > + * or may not be propagated to the other path depending on HW capability. > + * > + * RTE_FLOW_ITEM_TYPE_META matches metadata. > + */ > +struct rte_flow_action_set_meta { > + rte_be32_t data; > + rte_be32_t mask; > +}; > + > +/* Mbuf dynamic field offset for metadata. */ > +extern int rte_flow_dynf_metadata_offs; > + > +/* Mbuf dynamic field flag mask for metadata. */ > +extern uint64_t rte_flow_dynf_metadata_mask; > + > +/* Mbuf dynamic field pointer for metadata. */ > +#define RTE_FLOW_DYNF_METADATA(m) \ > + RTE_MBUF_DYNFIELD((m), rte_flow_dynf_metadata_offs, uint32_t *) > + > +/* Mbuf dynamic flag for metadata. */ > +#define PKT_RX_DYNF_METADATA (rte_flow_dynf_metadata_mask) > + I wonder if helpers like this wouldn't be better, because they combine the flag and the field: /** * Set metadata dynamic field and flag in mbuf. * * rte_flow_dynf_metadata_register() must have been called first. */ __rte_experimental static inline void rte_mbuf_dyn_metadata_set(struct rte_mbuf *m, uint32_t metadata) { *RTE_MBUF_DYNFIELD(m, rte_flow_dynf_metadata_offs, uint32_t *) = metadata; m->ol_flags |= rte_flow_dynf_metadata_mask; } /** * Get metadata dynamic field value in mbuf. * * rte_flow_dynf_metadata_register() must have been called first. */ __rte_experimental static inline int rte_mbuf_dyn_metadata_get(const struct rte_mbuf *m, uint32_t *metadata) { if ((m->ol_flags & rte_flow_dynf_metadata_mask) == 0) return -1; *metadata = *RTE_MBUF_DYNFIELD(m, rte_flow_dynf_metadata_offs, uint32_t *); return 0; } /** * Delete the metadata dynamic flag in mbuf. * * rte_flow_dynf_metadata_register() must have been called first. */ __rte_experimental static inline void rte_mbuf_dyn_metadata_del(struct rte_mbuf *m) { m->ol_flags &= ~rte_flow_dynf_metadata_mask; } > /* > * Definition of a single action. > * > @@ -2533,6 +2588,32 @@ enum rte_flow_conv_op { > }; > > /** > + * Check if mbuf dynamic field for metadata is registered. > + * > + * @return > + * True if registered, false otherwise. > + */ > +__rte_experimental > +static inline int > +rte_flow_dynf_metadata_avail(void) { > + return !!rte_flow_dynf_metadata_mask; > +} _registered() instead of _avail() ? > + > +/** > + * Register mbuf dynamic field and flag for metadata. > + * > + * This function must be called prior to use SET_META action in order to > + * register the dynamic mbuf field. Otherwise, the data cannot be delivered to > + * application. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set. > + */ > +__rte_experimental > +int > +rte_flow_dynf_metadata_register(void); > + > +/** > * Check whether a flow rule can be created on a given port. > * > * The flow rule is validated for correctness and whether it could be accepted > diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h > index 6e2c816..4ff33ac 100644 > --- a/lib/librte_mbuf/rte_mbuf_dyn.h > +++ b/lib/librte_mbuf/rte_mbuf_dyn.h > @@ -160,4 +160,12 @@ int rte_mbuf_dynflag_lookup(const char *name, > */ > #define RTE_MBUF_DYNFIELD(m, offset, type) ((type)((uintptr_t)(m) + (offset))) > > +/** > + * Flow metadata dynamic field definitions. > + */ > +#define MBUF_DYNF_METADATA_NAME "flow-metadata" > +#define MBUF_DYNF_METADATA_SIZE sizeof(uint32_t) > +#define MBUF_DYNF_METADATA_ALIGN __alignof__(uint32_t) > +#define MBUF_DYNF_METADATA_FLAGS 0 If this flag is only to be used in rte_flow, it can stay in rte_flow. The name should follow the function name conventions, I suggest "rte_flow_metadata". If the flag is going to be used in several places in dpdk (rte_flow, pmd, app, ...), I wonder if it shouldn't be defined it in rte_mbuf_dyn.c. I mean: ==== /* rte_mbuf_dyn.c */ const struct rte_mbuf_dynfield rte_mbuf_dynfield_flow_metadata = { ... }; int rte_mbuf_dynfield_flow_metadata_offset = -1; const struct rte_mbuf_dynflag rte_mbuf_dynflag_flow_metadata = { ... }; int rte_mbuf_dynflag_flow_metadata_bitnum = -1; int rte_mbuf_dyn_flow_metadata_register(void) { ... } /* rte_mbuf_dyn.h */ extern const struct rte_mbuf_dynfield rte_mbuf_dynfield_flow_metadata; extern int rte_mbuf_dynfield_flow_metadata_offset; extern const struct rte_mbuf_dynflag rte_mbuf_dynflag_flow_metadata; extern int rte_mbuf_dynflag_flow_metadata_bitnum; ...helpers to set/get metadata... === Centralizing the definitions of non-private dynamic fields/flags in rte_mbuf_dyn may help other people to reuse a field that is well described if it match their use-case. In your case, what is carried by metadata? Could it be reused by others? I think some more description is needed. Regards, Olivier