From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DATE_IN_PAST_06_12, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C1EACA9EB6 for ; Wed, 23 Oct 2019 09:26:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1F8E82084C for ; Wed, 23 Oct 2019 09:26:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F8E82084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C23A21C00D; Wed, 23 Oct 2019 11:25:56 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 724D01BFEE for ; Wed, 23 Oct 2019 11:25:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 02:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,220,1569308400"; d="scan'208";a="397983771" Received: from silpixa00399838.ir.intel.com (HELO silpixa00399838.ger.corp.intel.com) ([10.237.223.140]) by fmsmga005.fm.intel.com with ESMTP; 23 Oct 2019 02:25:48 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: bruce.richardson@intel.com, thomas@monjalon.net, ray.kinsella@intel.com Date: Wed, 23 Oct 2019 01:07:50 +0000 Message-Id: <20191023010754.65172-3-kevin.laatz@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191023010754.65172-1-kevin.laatz@intel.com> References: <20191023010754.65172-1-kevin.laatz@intel.com> Subject: [dpdk-dev] [RFC 2/6] build: use meson warning levels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: From: Bruce Richardson Rather than trying to manage all the cflags ourselves, we can use meson warning levels to give the user more control. We remove the Wextra flag and rely on meson to add it, by bumping up our default warning level. Signed-off-by: Bruce Richardson --- config/meson.build | 40 +++++++++++++++++++++------------------- meson.build | 3 ++- 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/config/meson.build b/config/meson.build index b383e79c0..3bcfe0668 100644 --- a/config/meson.build +++ b/config/meson.build @@ -141,31 +141,33 @@ endif # add -include rte_config to cflags add_project_arguments('-include', 'rte_config.h', language: 'c') -# enable extra warnings and disable any unwanted warnings +# enable extra warnings and disable any unwanted warnings. "-Wall" is added +# by meson at warning level 1, and "-Wextra" at level 2, so we can omit +# those. Add extra warnings at level 2 or above. (2 is default level). warning_flags = [ - # -Wall is added by meson by default, so add -Wextra only - '-Wextra', - - # additional warnings in alphabetical order - '-Wcast-qual', - '-Wdeprecated', - '-Wformat-nonliteral', - '-Wformat-security', - '-Wmissing-declarations', - '-Wmissing-prototypes', - '-Wnested-externs', - '-Wold-style-definition', - '-Wpointer-arith', - '-Wsign-compare', - '-Wstrict-prototypes', - '-Wundef', - '-Wwrite-strings', - # globally disabled warnings '-Wno-address-of-packed-member', '-Wno-packed-not-aligned', '-Wno-missing-field-initializers' ] +if get_option('warning_level').to_int() >= 2 + warning_flags += [ + # additional warnings in alphabetical order + '-Wcast-qual', + '-Wdeprecated', + '-Wformat-nonliteral', + '-Wformat-security', + '-Wmissing-declarations', + '-Wmissing-prototypes', + '-Wnested-externs', + '-Wold-style-definition', + '-Wpointer-arith', + '-Wsign-compare', + '-Wstrict-prototypes', + '-Wundef', + '-Wwrite-strings', + ] +endif if not dpdk_conf.get('RTE_ARCH_64') # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!! warning_flags += '-Wno-pointer-to-int-cast' diff --git a/meson.build b/meson.build index b77ccd6ef..dd83b0bcb 100644 --- a/meson.build +++ b/meson.build @@ -8,7 +8,8 @@ project('DPDK', 'C', files('VERSION')).stdout().strip(), license: 'BSD', default_options: ['buildtype=debugoptimized', - 'default_library=static'], + 'default_library=static', + 'warning_level=2'], meson_version: '>= 0.47.1' ) -- 2.17.1