From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472E1CA9ECB for ; Thu, 31 Oct 2019 16:40:57 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C53B92087F for ; Thu, 31 Oct 2019 16:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="QC3pHLj3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C53B92087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0AEA1C2F8; Thu, 31 Oct 2019 17:40:55 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 1B27C1C2F4 for ; Thu, 31 Oct 2019 17:40:55 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id j22so4404359pgh.3 for ; Thu, 31 Oct 2019 09:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CdjjDjRWAHfhHo2K+odNILvqR7dkhGhG0UtqGFNlPRs=; b=QC3pHLj38YJF7u9RUG0xH82plt3MYwnPgx9KsVhzopZlEpMrJDMFhPx5MN7IN1FD8O gIhYVo6k7MhPEYwHZwLM29xkKICgjPfpiQovELUOP+582qgNFX6TX2KB9BDqzkZQdtzI OM1evhH2MJAquSK7aPR+rkdHLYyg/VQscyvNc38CMVbvwQEQjo89zzV+ASbaJgQjBMYU ciEMRB67LbOs7axdmM46RBSExfJNS+Xj4P6qrKA+ng/aTMPjTtEIeTR0g8lVsAuXtp+G X+aFdjXPdaFyPhIvHC66vw2ha6aWzEoI0HwO3++Jizk8wjrpML7FxYAiWd6jS/CmM0BQ udKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CdjjDjRWAHfhHo2K+odNILvqR7dkhGhG0UtqGFNlPRs=; b=b2kIVGsxfV2uSwwxINnzfJwezlg6O+EqtW6IQzh/bmuwsTxejlzFQ/osfLn51MUnFe 6rFC9IFW3SAMD7oYa39OHqA7Qvwl1Phzq+xIFH8p6SNvqGn7FgDFS2m+RQresFCAXT5J o0gn/wO5MRRiLdB9sKXTNBBZSKWwCTIeKArQ7xrU9VGqQw08681QA+rg3JYcs0+j3VA4 B99ST8tS69v6VU39f8/pIvMq7bGGIxtfu8fCTLcSuvmmSXWP1016dhiu6YTcA37dg0il VL7sphLYMoDrTI66n2qFVDEYBrmS+KRvUz3YsWV8IBDGZWftDyb+OUHyB1O8I5Ba5bSf zYRw== X-Gm-Message-State: APjAAAUNaCqdZPH3xjv0JV6/eI0J+4FZx463VI0PKn/0jTtc4kuWrUJP /gZWfPeXViOeItt6Hs51bjWnjQ6WfqmBsg== X-Google-Smtp-Source: APXvYqwF4QFHD0FMVCEBW5Qgu04Ac5qLIYrFNTBMJMAuLpKjHq5mh30o83/p4wggbP/JZ1VOQHWU+Q== X-Received: by 2002:a63:7b5c:: with SMTP id k28mr3913517pgn.442.1572540054056; Thu, 31 Oct 2019 09:40:54 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q13sm13526369pjq.0.2019.10.31.09.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2019 09:40:53 -0700 (PDT) Date: Thu, 31 Oct 2019 09:40:45 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Message-ID: <20191031094045.1ee45f3b@hermes.lan> In-Reply-To: <8c2d6a91-f5f1-57e0-61f7-8d07542ae305@solarflare.com> References: <20190811160607.16441-1-stephen@networkplumber.org> <20190919131729.28681-1-stephen@networkplumber.org> <20190919131729.28681-2-stephen@networkplumber.org> <8c2d6a91-f5f1-57e0-61f7-8d07542ae305@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: expose basic xstats for driver use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 26 Sep 2019 15:46:52 +0300 Andrew Rybchenko wrote: > On 9/19/19 4:17 PM, Stephen Hemminger wrote: > > Avoid duplication by having generic basic xstats available > > for use by drivers. A later patch uses this for failsafe > > driver. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Gaetan Rivet > > Acked-by: Andrew Rybchenko > > > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > > index 936ff8c98651..489889a72203 100644 > > --- a/lib/librte_ethdev/rte_ethdev_driver.h > > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > > @@ -208,6 +208,71 @@ rte_eth_linkstatus_get(const struct rte_eth_dev *dev, > > #endif > > } > > > > +/** > > + * @internal > > + * Get basic stats part of xstats for an ethernet device. > > + * > > + * @param dev > > + * Pointer to struct rte_eth_dev. > > + */ > > +__rte_experimental > > Does it make sense to mark internal API as experimental? > I thought that @internal is not a part of API/ABI. Checkpatch picks on it