DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
	aostruszka@marvell.com, Aaron Conole <aconole@redhat.com>,
	Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [dpdk-dev] [PATCH] ci: remove LTO job
Date: Mon, 11 Nov 2019 13:57:02 +0000
Message-ID: <20191111135702.GD1444@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8yRgKA0sFin8YUDx42Z6vQRUfNCbAJUY6vSpJfdRCL8ww@mail.gmail.com>

On Mon, Nov 11, 2019 at 01:27:23PM +0100, David Marchand wrote:
> On Mon, Nov 11, 2019 at 12:32 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote:
> > > 08/11/2019 20:32, David Marchand:
> > > > The LTO job using gcc-7 has two issues at the moment:
> > > > - warnings about implicit fallthroughs trigger build errors:
> > > >
> > > > In file included from ...common/include/rte_memory.h:22:0,
> > > >                  from ...linux/eal/eal_hugepage_info.c:24:
> > > > ...common/include/rte_common.h: In function ‘rte_str_to_size’:
> > > > ...common/include/rte_common.h:744:27: error: this statement may
> > > >   fall through [-Werror=implicit-fallthrough=]
> > > >   case 'G': case 'g': size *= 1024; /* fall-through */
> > > >                       ~~~~~^~~~~~~
> > > >
> > > > - if we disable this warning, linking the binaries takes too much time
> > > >   and the job is terminated by Travis because it reaches the maximum
> > > >   time limit
> > > >
> > > > Fixes: 098cc0fea3be ("build: add option to enable LTO")
> > > >
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > >
> > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > Thank you, I should have tested it in Travis before merging.
> > >
> > I'm also interested in whether someone can give steps to reproduce this
> > issue outside of the Travis environment. I've tested with gcc-7 on both
> > Ubuntu 16.04 (as used by Travis) and Ubuntu 18.04, and the builds I tested
> > all worked fine, without any warnings being seen. I am therefore wondering
> > what is special about the travis setup that causes it to fail.
> 
> Did you try with the custom apt repository that the LTO job was using ?
> -      apt:
> -        sources:
> -            - ubuntu-toolchain-r-test
> 
Yes, that repo was needed to get gcc-7 on Ubuntu 16.04, IIRC

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 19:32 David Marchand
2019-11-08 19:55 ` Thomas Monjalon
2019-11-08 20:07   ` David Marchand
2019-11-11 11:31   ` Bruce Richardson
2019-11-11 12:27     ` David Marchand
2019-11-11 13:57       ` Bruce Richardson [this message]
2019-11-12  8:55         ` Andrzej Ostruszka

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111135702.GD1444@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=aconole@redhat.com \
    --cc=aostruszka@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maicolgabriel@hotmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git