From: Yasufumi Ogawa <yasufum.o@gmail.com> To: anatoly.burakov@intel.com, konstantin.ananyev@intel.com, david.marchand@redhat.com, dev@dpdk.org Cc: yasufumi.ogawa.gy@hco.ntt.co.jp, Yasufumi Ogawa <yasufum.o@gmail.com> Subject: [dpdk-dev] [PATCH v8 0/1] fbarray: fix duplicated fbarray file in secondary Date: Wed, 27 Nov 2019 17:48:25 +0900 Message-ID: <20191127084826.3519-1-yasufum.o@gmail.com> (raw) In-Reply-To: <20191113214346.33749-1-yasufum.o@gmail.com> In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if several secondaries run as app containers because each of containerized secondary has PID 1, and failed to reserve unique name other than first one. To reserve unique name in each of containers, use hostname in addition to PID. --- v2: * fix typo in commit message v3: * add fclose() after if getting hostname with fscan() is failed v4: * Increase the size of proc_id to 33 and add boundary in calling fscan() v5: * revise title to reflect the issue * use gethostname() instead of getting from `etc/hostname` * use HOST_NAME_MAX for size of string for hostname v6: * change to use hostname and pid to cover both of host and container cases * change RTE_FBARRAY_NAME_LEN to NAME_MAX to reserve enough size for filename v7: * discard changing RTE_FBARRAY_NAME_LEN to NAME_MAX to avoid breaking ABI * introduce int fbarray_sec_name_len instead of RTE_FBARRAY_NAME_LEN to define long filename only for secondary process * replace the order of postfixes of pid and hostname v8: * change RTE_FBARRAY_NAME_LEN to the maximum size for secondary * fix warning of Signed-off-by --- Yasufumi Ogawa (1): fbarray: fix duplicated fbarray file in secondary lib/librte_eal/common/include/rte_fbarray.h | 7 ++++++- lib/librte_eal/linux/eal/eal_memalloc.c | 11 ++++++++--- 2 files changed, 14 insertions(+), 4 deletions(-) -- 2.17.1
next prev parent reply index Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-16 1:59 [dpdk-dev] [PATCH] fbarray: get fbarrays from containerized secondary ogawa.yasufumi 2019-04-16 3:43 ` [dpdk-dev] [PATCH v2 0/1] Get " ogawa.yasufumi 2019-04-16 3:43 ` [dpdk-dev] [PATCH v2 1/1] fbarray: get " ogawa.yasufumi 2019-07-04 20:17 ` Thomas Monjalon 2019-07-05 8:53 ` Burakov, Anatoly 2019-07-09 10:22 ` Yasufumi Ogawa 2019-07-09 10:24 ` Burakov, Anatoly 2019-07-09 10:26 ` Burakov, Anatoly 2019-07-11 9:37 ` Yasufumi Ogawa 2019-07-11 9:43 ` Burakov, Anatoly 2019-07-11 10:31 ` [dpdk-dev] [PATCH v3 0/1] " yasufum.o 2019-07-11 10:31 ` [dpdk-dev] [PATCH v3 1/1] " yasufum.o 2019-07-11 10:53 ` Burakov, Anatoly 2019-07-11 11:57 ` Yasufumi Ogawa 2019-07-11 13:14 ` Burakov, Anatoly 2019-07-12 2:22 ` Yasufumi Ogawa 2019-07-22 1:06 ` Ogawa Yasufumi 2019-07-22 9:33 ` Burakov, Anatoly 2019-07-22 9:25 ` Burakov, Anatoly 2019-07-24 8:20 ` [dpdk-dev] [PATCH v4 0/1] " yasufum.o 2019-07-24 8:20 ` [dpdk-dev] [PATCH v4 1/1] " yasufum.o 2019-07-24 9:59 ` Burakov, Anatoly 2019-07-30 8:16 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2019-07-30 9:18 ` Burakov, Anatoly 2019-07-31 5:48 ` Yasufumi Ogawa 2019-10-11 9:36 ` [dpdk-dev] " David Marchand 2019-10-25 15:36 ` David Marchand 2019-10-25 19:54 ` Yasufumi Ogawa 2019-10-26 16:15 ` David Marchand 2019-10-26 18:11 ` Yasufumi Ogawa 2019-10-28 8:07 ` [dpdk-dev] [PATCH v5 0/1] fbarray: fix duplicated fbarray file in secondary yasufum.o 2019-10-28 8:07 ` [dpdk-dev] [PATCH v5 1/1] " yasufum.o 2019-10-29 12:03 ` Ananyev, Konstantin 2019-10-30 13:42 ` Yasufumi Ogawa 2019-10-30 19:00 ` Ananyev, Konstantin 2019-10-31 10:03 ` Yasufumi Ogawa 2019-10-31 10:32 ` Ananyev, Konstantin 2019-11-01 9:04 ` [dpdk-dev] [PATCH v6 0/1] " yasufum.o 2019-11-01 9:04 ` [dpdk-dev] [PATCH v6 1/1] " yasufum.o 2019-11-01 12:01 ` Ananyev, Konstantin 2019-11-04 10:20 ` Burakov, Anatoly 2019-11-05 10:13 ` David Marchand 2019-11-05 11:31 ` Burakov, Anatoly 2019-11-05 11:41 ` Ananyev, Konstantin 2019-11-06 10:37 ` Burakov, Anatoly 2019-11-08 3:19 ` Yasufumi Ogawa 2019-11-13 21:43 ` [dpdk-dev] [PATCH v7 0/1] " yasufum.o 2019-11-13 21:43 ` [dpdk-dev] [PATCH v7 1/1] " yasufum.o 2019-11-14 10:01 ` Burakov, Anatoly 2019-11-14 11:42 ` Yasufumi Ogawa 2019-11-14 12:27 ` David Marchand 2019-11-26 19:40 ` Yasufumi Ogawa 2019-11-27 10:26 ` Burakov, Anatoly 2019-11-29 5:44 ` Yasufumi Ogawa 2019-12-02 10:43 ` Burakov, Anatoly 2019-12-05 20:13 ` Yasufumi Ogawa 2019-11-14 12:55 ` David Marchand 2019-11-14 17:32 ` Ananyev, Konstantin 2019-11-27 8:48 ` Yasufumi Ogawa [this message] 2019-11-27 8:48 ` [dpdk-dev] [PATCH v8 " Yasufumi Ogawa 2019-12-06 10:44 ` Burakov, Anatoly 2019-12-06 13:18 ` Yasufumi Ogawa 2020-02-14 7:46 ` Yasufumi Ogawa 2020-02-14 15:08 ` David Marchand 2020-02-14 15:29 ` Thomas Monjalon 2020-02-17 12:54 ` Yasufumi Ogawa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191127084826.3519-1-yasufum.o@gmail.com \ --to=yasufum.o@gmail.com \ --cc=anatoly.burakov@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=yasufumi.ogawa.gy@hco.ntt.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git