From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091DCC432C3 for ; Wed, 27 Nov 2019 16:51:56 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9443B20665 for ; Wed, 27 Nov 2019 16:51:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9443B20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59BEC1BE92; Wed, 27 Nov 2019 17:51:54 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 97CFE1BE91 for ; Wed, 27 Nov 2019 17:51:52 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 08:51:51 -0800 X-IronPort-AV: E=Sophos;i="5.69,250,1571727600"; d="scan'208";a="203130895" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Nov 2019 08:51:49 -0800 Date: Wed, 27 Nov 2019 16:51:46 +0000 From: Bruce Richardson To: Ali Alnubani Cc: "dev@dpdk.org" Message-ID: <20191127165146.GB2372@bricha3-MOBL.ger.corp.intel.com> References: <20191126081346.22889-1-alialnu@mellanox.com> <20191126081346.22889-2-alialnu@mellanox.com> <20191126095155.GA1622@bricha3-MOBL.ger.corp.intel.com> <20191126120037.GB1629@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu as a prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 27, 2019 at 03:54:55PM +0000, Ali Alnubani wrote: > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, November 26, 2019 2:01 PM > > To: Ali Alnubani > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add pkg-config-aarch64-linux-gnu > > as a prerequisite > > > > On Tue, Nov 26, 2019 at 10:41:08AM +0000, Ali Alnubani wrote: > > > Hi Bruce, > > > > > > > -----Original Message----- > > > > From: Bruce Richardson > > > > Sent: Tuesday, November 26, 2019 11:52 AM > > > > To: Ali Alnubani > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add > > > > pkg-config-aarch64-linux-gnu as a prerequisite > > > > > > > > On Tue, Nov 26, 2019 at 08:14:25AM +0000, Ali Alnubani wrote: > > > > > The package pkg-config-aarch64-linux-gnu is required with meson > > > > > for detecting dependencies installed in nonstandard paths. > > > > > > > > > > Signed-off-by: Ali Alnubani > > > > > --- > > > > > doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 8 ++++++++ > > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > > > > > b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > > > > > index e799b0ba4..f00f9b130 100644 > > > > > --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > > > > > +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst > > > > > @@ -122,6 +122,14 @@ To compile for non-NUMA targets, without > > > > > compiling the kernel modules, use the f Meson Cross Compiling > > > > > DPDK > > > > > -------------------------- > > > > > > > > > > +Meson depends on pkgconfig to find the dependencies that are > > > > > +installed in nonstandard paths. The package > > > > > +`pkg-config-aarch64-linux-gnu` is required in this case. To > > > > > +install it in > > > > Ubuntu: > > > > > + > > > > > +.. code-block:: console > > > > > + > > > > > + sudo apt-get install pkg-config-aarch64-linux-gnu > > > > > + > > > > > To cross-compile DPDK on a desired target machine we can use the > > > > > following > > > > > command:: > > > > > > > > Is there a package for Fedora or similar Redhat-derived distros? > > > > > > I don't think it's available. Should I add instructions on how to cross build it > > instead of the apt-get example? > > > > > I think you might need both. Distro-instructions is probably best, but there > > are a lot of people not using Ubuntu, I suspect. > > > > Following patch 1, if pkg-config is added to all the cross-build files, does that > > prevent previously working cross-builds from passing due to the lack of the > > pkg-config package? Do the travis jobs need updating, for example? > > Cross compiling pkg-config from source requires glib, which in turn requires other packages (libffi and pcre). > Do we want to add instructions to cross build that dependency tree? > > I opened a pull request to the Github mirror to make sure I didn't break the CI: > https://github.com/DPDK/dpdk/pull/14 > If the binary 'aarch64-linux-gnu-pkg-config' isn't found, Meson seems to just show the following warnings, but it doesn't fail with error: > ''' > Did not find pkg-config by name 'aarch64-linux-gnu-pkg-config' > Found Pkg-config: NO > ''' > > I'll send v2 with an additional patch to add the package to the list of requirements for Travis's environment. > > So long as is doesn't break something that was previously working I'm ok with this set.