From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4A4C432C3 for ; Thu, 28 Nov 2019 14:30:17 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 27A9A2071F for ; Thu, 28 Nov 2019 14:30:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27A9A2071F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A4B829CB; Thu, 28 Nov 2019 15:30:16 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8AD4528EE for ; Thu, 28 Nov 2019 15:30:14 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2019 06:30:12 -0800 X-IronPort-AV: E=Sophos;i="5.69,253,1571727600"; d="scan'208";a="199540996" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 28 Nov 2019 06:30:11 -0800 Date: Thu, 28 Nov 2019 14:30:08 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, john.mcnamara@intel.com Message-ID: <20191128143008.GC2386@bricha3-MOBL.ger.corp.intel.com> References: <20191122160359.11625-1-bruce.richardson@intel.com> <1739137.btLB4cIjLT@xps> <20191128141107.GB2386@bricha3-MOBL.ger.corp.intel.com> <2316895.6DYn9dXaqE@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2316895.6DYn9dXaqE@xps> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH 1/8] doc: update Linux GSG system requirements section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 28, 2019 at 03:22:05PM +0100, Thomas Monjalon wrote: > 28/11/2019 15:11, Bruce Richardson: > > On Thu, Nov 28, 2019 at 12:51:27PM +0100, Thomas Monjalon wrote: > > > 22/11/2019 17:03, Bruce Richardson: > > > [...] > > > > -* GNU ``make``. > > > > +* General development tools including ``make``, and a supported C compiler such as ``gcc`` or ``clang``. > > > > > > Why referring to make and not meson? > > > > Because even with meson build we still use make for building kernel > > modules, and this first bullet item is all about getting the basic build > > packages which come from build-essential etc. Make is part of that build > > tools group on distros, meson and ninja are not. > > OK > > > > > -* gcc: versions 4.9 or later is recommended for all platforms. > > > > - On some distributions, some specific compiler flags and linker flags are enabled by > > > > - default and affect performance (``-fstack-protector``, for example). Please refer to the documentation > > > > - of your distribution and to ``gcc -dumpspecs``. > > > > > > I think we need to keep some compiler requirement somewhere. > > > What do you suggest? > > > > I'm happy to keep this compiler requirements in here. Is 4.9 still > > regularly tested with DPDK to ensure it works? Also, if we put in a GCC > > requirement, do we not also need to put in a clang one? For recent distros > > is this really something most users need to worry about? > > It allows us to know which compiler we must support. > And for distributions, it can help. > I think we should have clang version too. > Ok, I'll add 4.9 recommendation in V2. If we have a minimum clang version you want included, I can add that too, if someone gets it to me in time :-) > > > > +* Meson (v0.47.1+) and ninja > > > > > > > > + * Recommended to use the latest versions from Python's "pip" repository: > > > > + ``pip3 install meson ninja`` > > > > > > Why recommending pip? Is 0.47.1 enough? > > > > It is enough, this was done again in the interests of simplification - > > rather than worry about what versions are in what distro and having the > > user check, it simplifies things if everyone just uses pip, which is why I > > recommend it. > > I think we should let users take the responsibility of using their distro > package or pip. > Recommending pip is a little pushy. > Ok, will add possibility of using distro packages in V2.