From: Ye Xiaolong <xiaolong.ye@intel.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: Igor Ryzhov <iryzhov@nfware.com>, Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson Date: Tue, 3 Dec 2019 13:33:19 +0800 Message-ID: <20191203053319.GA3210@intel.com> (raw) In-Reply-To: <20191202120819.GA25@bricha3-MOBL.ger.corp.intel.com> On 12/02, Bruce Richardson wrote: >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: >> On 12/02, Igor Ryzhov wrote: >> >We should at least install it into /lib/modules/kernel-version. For >> >convenience, dpdk modules are installed into >> >/lib/modules/kernel-version/extra/dpdk. >> >In the cross-compilation case, you can use DEST_DIR to set some prefix. >> > >> >I don't really see the issue here. The description clearly says that >> >headers must be in $kernel_dir/build which is usually a symlink >> >to /usr/src/linux-headers-kernel-version. >> >Just set kernel_dir correctly and there won't be compilation failure. >> >> I think for cross-compilation case, user should be allowed to specify any kernel >> src dir (it doesn't have to be /lib/modules/kernel-version) in his local system >> as kernel_dir that doesn't contain the build dir, in this case, current meson >> build will skip kernel module compilation. >> > >I don't think we can take this change as the default, since the previous >fix was put in for good reason. > >However, perhaps we can attempt to support both, using the checks below for >"make kernelversion" in kernel/linux/meson.build. We can attempt using the >directory with /build (as now) and then if that fails attempt without it (or >vice versa). After a second thought, I think it'd be better that we unify the meaning of kernel_dir for both cases, it should be aligned with make's RTE_KERNELDIR variable that specify the directory contains kernel src code (or header), then we don't need to distinguish these 2 cases in check (make kernelversion) phase, we just need to assign different install dirs, For normal case: kernel_dir=/lib/modules/<kernel_version>/build install_dir=/lib/modules/<kernel_version>/extra/dpdk For cross compilation case: kernel_dir=<Any kernel src dir specified by user> install_dir=<Any kernel src dir specified by user>/extra/dpdk What do you think (I've sent v2 according to above description)? Thanks, Xiaolong > >/Bruce
next prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-02 6:14 Xiaolong Ye 2019-12-02 8:10 ` Igor Ryzhov 2019-12-02 8:39 ` Ye Xiaolong 2019-12-02 9:16 ` Igor Ryzhov 2019-12-02 11:34 ` Ye Xiaolong 2019-12-02 12:08 ` Bruce Richardson 2019-12-02 15:44 ` Ye Xiaolong 2019-12-03 5:33 ` Ye Xiaolong [this message] 2019-12-03 10:10 ` Bruce Richardson 2019-12-03 5:29 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye 2019-12-03 10:11 ` Bruce Richardson 2019-12-03 12:33 ` Ye Xiaolong 2019-12-03 13:58 ` Bruce Richardson 2019-12-03 15:01 ` Ye Xiaolong 2019-12-03 15:59 ` [dpdk-dev] [PATCH v3] " Xiaolong Ye 2019-12-04 13:51 ` Luca Boccassi 2019-12-04 14:18 ` Ye Xiaolong 2019-12-04 15:12 ` Bruce Richardson 2019-12-08 1:26 ` Ye Xiaolong 2019-12-09 12:12 ` Bruce Richardson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191203053319.GA3210@intel.com \ --to=xiaolong.ye@intel.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=iryzhov@nfware.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git