DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, arybchenko@solarflare.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6
Date: Wed, 4 Dec 2019 08:08:27 -0800
Message-ID: <20191204080827.154a5271@hermes.lan> (raw)
In-Reply-To: <20191204150002.4824-1-david.marchand@redhat.com>

On Wed,  4 Dec 2019 16:00:02 +0100
David Marchand <david.marchand@redhat.com> wrote:

> Previous fix gives hiccups to gcc on RHEL 7.6:
> 
> == Build lib/librte_eal/linux/eal
>   CC eal_interrupts.o
> ...lib/librte_eal/linux/eal/eal_interrupts.c: In function
>   ‘eal_intr_thread_main’:
> ...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing
>   initializer for field ‘events’ of ‘struct epoll_event’
>   [-Werror=missing-field-initializers]
>   struct epoll_event ev = { };
>          ^
> In file included from ...lib/librte_eal/linux/eal/eal_interrupts.c:15:0:
> /usr/include/sys/epoll.h:89:12: note: ‘events’ declared here
>    uint32_t events; /* Epoll events */
>             ^
> ...lib/librte_eal/linux/eal/eal_interrupts.c: At top level:
> cc1: error: unrecognized command line option
>   "-Wno-address-of-packed-member" [-Werror]
> cc1: all warnings being treated as errors
> 
> Fixes: e0ab8020ac2a ("eal/linux: fix uninitialized data valgrind warning")
> Cc: stable@dpdk.org
> 
> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/librte_eal/linux/eal/eal_interrupts.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c
> index 2cd537ba4..14ebb108c 100644
> --- a/lib/librte_eal/linux/eal/eal_interrupts.c
> +++ b/lib/librte_eal/linux/eal/eal_interrupts.c
> @@ -1045,8 +1045,6 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)
>  static __attribute__((noreturn)) void *
>  eal_intr_thread_main(__rte_unused void *arg)
>  {
> -	struct epoll_event ev = { };
> -
>  	/* host thread, never break out */
>  	for (;;) {
>  		/* build up the epoll fd with all descriptors we are to
> @@ -1078,8 +1076,11 @@ eal_intr_thread_main(__rte_unused void *arg)
>  		rte_spinlock_lock(&intr_lock);
>  
>  		TAILQ_FOREACH(src, &intr_sources, next) {
> +			struct epoll_event ev;
> +
>  			if (src->callbacks.tqh_first == NULL)
>  				continue; /* skip those with no callbacks */
> +			memset(&ev, 0, sizeof(ev));
>  			ev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP;
>  			ev.data.fd = src->intr_handle.fd;
>  

Never mind, memset does the same thing.
Not a fan of missing field initializer warnings.

  parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 15:00 David Marchand
2019-12-04 15:37 ` Stephen Hemminger
2019-12-04 15:55   ` David Marchand
2019-12-04 16:08 ` Stephen Hemminger [this message]
2019-12-04 19:22 ` [dpdk-dev] [dpdk-stable] " David Marchand

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204080827.154a5271@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=arybchenko@solarflare.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git