* [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6
@ 2019-12-04 15:00 David Marchand
2019-12-04 15:37 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Marchand @ 2019-12-04 15:00 UTC (permalink / raw)
To: dev; +Cc: stephen, arybchenko, stable
Previous fix gives hiccups to gcc on RHEL 7.6:
== Build lib/librte_eal/linux/eal
CC eal_interrupts.o
...lib/librte_eal/linux/eal/eal_interrupts.c: In function
‘eal_intr_thread_main’:
...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing
initializer for field ‘events’ of ‘struct epoll_event’
[-Werror=missing-field-initializers]
struct epoll_event ev = { };
^
In file included from ...lib/librte_eal/linux/eal/eal_interrupts.c:15:0:
/usr/include/sys/epoll.h:89:12: note: ‘events’ declared here
uint32_t events; /* Epoll events */
^
...lib/librte_eal/linux/eal/eal_interrupts.c: At top level:
cc1: error: unrecognized command line option
"-Wno-address-of-packed-member" [-Werror]
cc1: all warnings being treated as errors
Fixes: e0ab8020ac2a ("eal/linux: fix uninitialized data valgrind warning")
Cc: stable@dpdk.org
Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/linux/eal/eal_interrupts.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c
index 2cd537ba4..14ebb108c 100644
--- a/lib/librte_eal/linux/eal/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal/eal_interrupts.c
@@ -1045,8 +1045,6 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)
static __attribute__((noreturn)) void *
eal_intr_thread_main(__rte_unused void *arg)
{
- struct epoll_event ev = { };
-
/* host thread, never break out */
for (;;) {
/* build up the epoll fd with all descriptors we are to
@@ -1078,8 +1076,11 @@ eal_intr_thread_main(__rte_unused void *arg)
rte_spinlock_lock(&intr_lock);
TAILQ_FOREACH(src, &intr_sources, next) {
+ struct epoll_event ev;
+
if (src->callbacks.tqh_first == NULL)
continue; /* skip those with no callbacks */
+ memset(&ev, 0, sizeof(ev));
ev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP;
ev.data.fd = src->intr_handle.fd;
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6
2019-12-04 15:00 [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6 David Marchand
@ 2019-12-04 15:37 ` Stephen Hemminger
2019-12-04 15:55 ` David Marchand
2019-12-04 16:08 ` Stephen Hemminger
2019-12-04 19:22 ` [dpdk-dev] [dpdk-stable] " David Marchand
2 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2019-12-04 15:37 UTC (permalink / raw)
To: David Marchand; +Cc: dev, arybchenko, stable
On Wed, 4 Dec 2019 16:00:02 +0100
David Marchand <david.marchand@redhat.com> wrote:
> + struct epoll_event ev;
This needs to be initialized (like it was above) or it will cause
warnings with valgrind about uninitialized data in system calls.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6
2019-12-04 15:37 ` Stephen Hemminger
@ 2019-12-04 15:55 ` David Marchand
0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2019-12-04 15:55 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Andrew Rybchenko, dpdk stable
On Wed, Dec 4, 2019 at 4:37 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 4 Dec 2019 16:00:02 +0100
> David Marchand <david.marchand@redhat.com> wrote:
>
> > + struct epoll_event ev;
> This needs to be initialized (like it was above) or it will cause
> warnings with valgrind about uninitialized data in system calls.
What is wrong with the memset?
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6
2019-12-04 15:00 [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6 David Marchand
2019-12-04 15:37 ` Stephen Hemminger
@ 2019-12-04 16:08 ` Stephen Hemminger
2019-12-04 19:22 ` [dpdk-dev] [dpdk-stable] " David Marchand
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2019-12-04 16:08 UTC (permalink / raw)
To: David Marchand; +Cc: dev, arybchenko, stable
On Wed, 4 Dec 2019 16:00:02 +0100
David Marchand <david.marchand@redhat.com> wrote:
> Previous fix gives hiccups to gcc on RHEL 7.6:
>
> == Build lib/librte_eal/linux/eal
> CC eal_interrupts.o
> ...lib/librte_eal/linux/eal/eal_interrupts.c: In function
> ‘eal_intr_thread_main’:
> ...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing
> initializer for field ‘events’ of ‘struct epoll_event’
> [-Werror=missing-field-initializers]
> struct epoll_event ev = { };
> ^
> In file included from ...lib/librte_eal/linux/eal/eal_interrupts.c:15:0:
> /usr/include/sys/epoll.h:89:12: note: ‘events’ declared here
> uint32_t events; /* Epoll events */
> ^
> ...lib/librte_eal/linux/eal/eal_interrupts.c: At top level:
> cc1: error: unrecognized command line option
> "-Wno-address-of-packed-member" [-Werror]
> cc1: all warnings being treated as errors
>
> Fixes: e0ab8020ac2a ("eal/linux: fix uninitialized data valgrind warning")
> Cc: stable@dpdk.org
>
> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_eal/linux/eal/eal_interrupts.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c
> index 2cd537ba4..14ebb108c 100644
> --- a/lib/librte_eal/linux/eal/eal_interrupts.c
> +++ b/lib/librte_eal/linux/eal/eal_interrupts.c
> @@ -1045,8 +1045,6 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)
> static __attribute__((noreturn)) void *
> eal_intr_thread_main(__rte_unused void *arg)
> {
> - struct epoll_event ev = { };
> -
> /* host thread, never break out */
> for (;;) {
> /* build up the epoll fd with all descriptors we are to
> @@ -1078,8 +1076,11 @@ eal_intr_thread_main(__rte_unused void *arg)
> rte_spinlock_lock(&intr_lock);
>
> TAILQ_FOREACH(src, &intr_sources, next) {
> + struct epoll_event ev;
> +
> if (src->callbacks.tqh_first == NULL)
> continue; /* skip those with no callbacks */
> + memset(&ev, 0, sizeof(ev));
> ev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP;
> ev.data.fd = src->intr_handle.fd;
>
Never mind, memset does the same thing.
Not a fan of missing field initializer warnings.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/linux: fix build error on RHEL 7.6
2019-12-04 15:00 [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6 David Marchand
2019-12-04 15:37 ` Stephen Hemminger
2019-12-04 16:08 ` Stephen Hemminger
@ 2019-12-04 19:22 ` David Marchand
2 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2019-12-04 19:22 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Andrew Rybchenko, dpdk stable
On Wed, Dec 4, 2019 at 4:00 PM David Marchand <david.marchand@redhat.com> wrote:
>
> Previous fix gives hiccups to gcc on RHEL 7.6:
>
> == Build lib/librte_eal/linux/eal
> CC eal_interrupts.o
> ...lib/librte_eal/linux/eal/eal_interrupts.c: In function
> ‘eal_intr_thread_main’:
> ...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing
> initializer for field ‘events’ of ‘struct epoll_event’
> [-Werror=missing-field-initializers]
> struct epoll_event ev = { };
> ^
> In file included from ...lib/librte_eal/linux/eal/eal_interrupts.c:15:0:
> /usr/include/sys/epoll.h:89:12: note: ‘events’ declared here
> uint32_t events; /* Epoll events */
> ^
> ...lib/librte_eal/linux/eal/eal_interrupts.c: At top level:
> cc1: error: unrecognized command line option
> "-Wno-address-of-packed-member" [-Werror]
> cc1: all warnings being treated as errors
>
> Fixes: e0ab8020ac2a ("eal/linux: fix uninitialized data valgrind warning")
> Cc: stable@dpdk.org
>
> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-04 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 15:00 [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6 David Marchand
2019-12-04 15:37 ` Stephen Hemminger
2019-12-04 15:55 ` David Marchand
2019-12-04 16:08 ` Stephen Hemminger
2019-12-04 19:22 ` [dpdk-dev] [dpdk-stable] " David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).