DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] eal: improve user notification for too low memzone segments
@ 2019-12-16 15:44 Artur Trybula
  2019-12-16 16:05 ` Trahe, Fiona
  2019-12-20 15:08 ` [dpdk-dev] [PATCH v2 0/1] eal: user notification improvement Artur Trybula
  0 siblings, 2 replies; 6+ messages in thread
From: Artur Trybula @ 2019-12-16 15:44 UTC (permalink / raw)
  To: dev, fiona.trahe, shallyv, adamx.dybkowski, marcinx.danilewicz,
	arturx.trybula, akhil.goyal

In case of too low number of memzone segements user notification
was misleading. This patch improves the description by providing
better explanation about the cause.

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
 lib/librte_eal/common/eal_common_memzone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c
index 99b8d6531..c1acbbb3c 100644
--- a/lib/librte_eal/common/eal_common_memzone.c
+++ b/lib/librte_eal/common/eal_common_memzone.c
@@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL, "%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n", __func__);
 		rte_errno = ENOSPC;
 		return NULL;
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: improve user notification for too low memzone segments
  2019-12-16 15:44 [dpdk-dev] [PATCH] eal: improve user notification for too low memzone segments Artur Trybula
@ 2019-12-16 16:05 ` Trahe, Fiona
  2019-12-20 15:08 ` [dpdk-dev] [PATCH v2 0/1] eal: user notification improvement Artur Trybula
  1 sibling, 0 replies; 6+ messages in thread
From: Trahe, Fiona @ 2019-12-16 16:05 UTC (permalink / raw)
  To: Trybula, ArturX, dev, Burakov, Anatoly; +Cc: shallyv, akhil.goyal, Trahe, Fiona

Including Anatoly as maintainer for lib/librte_eal/common/eal_common_mem*

> -----Original Message-----
> From: Trybula, ArturX <arturx.trybula@intel.com>
> Sent: Monday, December 16, 2019 3:44 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; shallyv@marvell.com; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; Danilewicz, MarcinX <marcinx.danilewicz@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] eal: improve user notification for too low memzone segments
> 
> In case of too low number of memzone segements user notification
> was misleading. This patch improves the description by providing
> better explanation about the cause.
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
>  lib/librte_eal/common/eal_common_memzone.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_memzone.c
> b/lib/librte_eal/common/eal_common_memzone.c
> index 99b8d6531..c1acbbb3c 100644
> --- a/lib/librte_eal/common/eal_common_memzone.c
> +++ b/lib/librte_eal/common/eal_common_memzone.c
> @@ -71,7 +71,7 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
> 
>  	/* no more room in config */
>  	if (arr->count >= arr->len) {
> -		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
> +		RTE_LOG(ERR, EAL, "%s(): Number of requested memzone segments exceeds
> RTE_MAX_MEMZONE\n", __func__);
>  		rte_errno = ENOSPC;
>  		return NULL;
>  	}
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2 0/1] eal: user notification improvement
  2019-12-16 15:44 [dpdk-dev] [PATCH] eal: improve user notification for too low memzone segments Artur Trybula
  2019-12-16 16:05 ` Trahe, Fiona
@ 2019-12-20 15:08 ` Artur Trybula
  2019-12-20 15:08   ` [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments Artur Trybula
  1 sibling, 1 reply; 6+ messages in thread
From: Artur Trybula @ 2019-12-20 15:08 UTC (permalink / raw)
  To: dev, fiona.trahe, shallyv, anatoly.burakov, adamx.dybkowski,
	marcinx.danilewicz, arturx.trybula, akhil.goyal

v2:
        - fixed coding style issue

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>

Artur Trybula (1):
  eal: improve user notification for too low memzone segments

 lib/librte_eal/common/eal_common_memzone.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments
  2019-12-20 15:08 ` [dpdk-dev] [PATCH v2 0/1] eal: user notification improvement Artur Trybula
@ 2019-12-20 15:08   ` Artur Trybula
  2020-01-14 10:40     ` Burakov, Anatoly
  0 siblings, 1 reply; 6+ messages in thread
From: Artur Trybula @ 2019-12-20 15:08 UTC (permalink / raw)
  To: dev, fiona.trahe, shallyv, anatoly.burakov, adamx.dybkowski,
	marcinx.danilewicz, arturx.trybula, akhil.goyal

In case of too low number of memzone segements user notification
was misleading. This patch improves the description by providing
better explanation about the cause.

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
 lib/librte_eal/common/eal_common_memzone.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c
index 99b8d6531..86f61369b 100644
--- a/lib/librte_eal/common/eal_common_memzone.c
+++ b/lib/librte_eal/common/eal_common_memzone.c
@@ -71,7 +71,9 @@ memzone_reserve_aligned_thread_unsafe(const char *name, size_t len,
 
 	/* no more room in config */
 	if (arr->count >= arr->len) {
-		RTE_LOG(ERR, EAL, "%s(): No more room in config\n", __func__);
+		RTE_LOG(ERR, EAL,
+		"%s(): Number of requested memzone segments exceeds RTE_MAX_MEMZONE\n",
+			__func__);
 		rte_errno = ENOSPC;
 		return NULL;
 	}
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments
  2019-12-20 15:08   ` [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments Artur Trybula
@ 2020-01-14 10:40     ` Burakov, Anatoly
  2020-01-20 17:53       ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Burakov, Anatoly @ 2020-01-14 10:40 UTC (permalink / raw)
  To: Artur Trybula, dev, fiona.trahe, shallyv, adamx.dybkowski,
	marcinx.danilewicz, akhil.goyal

On 20-Dec-19 3:08 PM, Artur Trybula wrote:
> In case of too low number of memzone segements user notification
> was misleading. This patch improves the description by providing
> better explanation about the cause.
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments
  2020-01-14 10:40     ` Burakov, Anatoly
@ 2020-01-20 17:53       ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-01-20 17:53 UTC (permalink / raw)
  To: Artur Trybula
  Cc: dev, fiona.trahe, shallyv, adamx.dybkowski, marcinx.danilewicz,
	akhil.goyal, Burakov, Anatoly

14/01/2020 11:40, Burakov, Anatoly:
> On 20-Dec-19 3:08 PM, Artur Trybula wrote:
> > In case of too low number of memzone segements user notification
> > was misleading. This patch improves the description by providing
> > better explanation about the cause.
> > 
> > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 15:44 [dpdk-dev] [PATCH] eal: improve user notification for too low memzone segments Artur Trybula
2019-12-16 16:05 ` Trahe, Fiona
2019-12-20 15:08 ` [dpdk-dev] [PATCH v2 0/1] eal: user notification improvement Artur Trybula
2019-12-20 15:08   ` [dpdk-dev] [PATCH v2 1/1] eal: improve user notification for too low memzone segments Artur Trybula
2020-01-14 10:40     ` Burakov, Anatoly
2020-01-20 17:53       ` Thomas Monjalon

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git