From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2C5C33C9E for ; Tue, 14 Jan 2020 16:19:32 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B4F5024658 for ; Tue, 14 Jan 2020 16:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4F5024658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10B2F1BFCF; Tue, 14 Jan 2020 17:19:31 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AD00D1BFCE for ; Tue, 14 Jan 2020 17:19:28 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 08:19:27 -0800 X-IronPort-AV: E=Sophos;i="5.69,433,1571727600"; d="scan'208";a="225587082" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.26]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Jan 2020 08:19:26 -0800 Date: Tue, 14 Jan 2020 16:19:23 +0000 From: Bruce Richardson To: David Marchand Cc: "Mcnamara, John" , Luca Boccassi , dev , Aaron Conole , Thomas Monjalon Message-ID: <20200114161923.GB1660@bricha3-MOBL.ger.corp.intel.com> References: <20200109115631.500056-1-bruce.richardson@intel.com> <20200110215205.513185-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v4 0/6] meson build improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 14, 2020 at 05:00:17PM +0100, David Marchand wrote: > On Fri, Jan 10, 2020 at 10:52 PM Bruce Richardson > wrote: > > > > These patches make some improvements to the meson build, particularly > > for documentation. They also remove many, but not all warnings issued > > by meson e.g. warnings about newer features unsupported in baseline. > > > > The biggest change is to improve the handling of the guide html docs. > > The change here is more significant, and the doc build now uses a > > wrapper script around sphinx. This wrapper script allows us to output > > correct dependency information for the sphinx build in a .d file. This > > .d file is processed by ninja (not meson) on build, so that any changes > > to doc files trigger a rebuild to the guides using sphinx. > > > > For now, the two patches which remove the meson version warnings are > > CC'ed to stable for backport, theoretically this who set could be > > backported if so desired, as all changes could be considered fixes to > > some degree or other, and nothing introduces a whole new feature. > > > > Note: for completeness and simplicity, previously submitted patch > > http://patches.dpdk.org/patch/64189/ is included in this set, and will > > be marked superceded in patchwork. > > > > V4: fix build with older sphinx > > > > V3: Shorten the python code in patch 5, and ensure style compliance as > > flagged by Aaron. > > > > V2: resend to correct email addresses > > Tried this series in Travis. It went fine through my own checks too. > > But OBS is not happy with Debian 10, Debian Next and Ubuntu >= 18.04. > The packaging fails when ninja can't find the 'doc' target. > Can you send on a link to the failure logs? I suspect this may be due to returning early from the doc folder if the document building is disabled (but need to see logs to confirm). However, I'm not sure it makes sense to have a doc target defined if doc building is disabled in build config.