From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com,
beilei.xing@intel.com, wei.zhao1@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode
Date: Mon, 9 Mar 2020 23:38:13 +0800 [thread overview]
Message-ID: <20200309153813.GC112283@intel.com> (raw)
In-Reply-To: <20200309141437.11800-2-haiyue.wang@intel.com>
On 03/09, Haiyue Wang wrote:
>A new DCF PMD will be introduced, which runs on Intel VF hardware, and
>it is a pure software design to control the advance functionality (such
>as switch, ACL) for rest of the VFs.
>
>So if the DCF (Device Config Function) mode is specified by the devarg
>'cap=dcf', then it will stop the PCI probe in the iavf PMD.
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/iavf/iavf_ethdev.c | 41 ++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
>diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
>index 34913f9c4..8ff26c0e7 100644
>--- a/drivers/net/iavf/iavf_ethdev.c
>+++ b/drivers/net/iavf/iavf_ethdev.c
>@@ -1416,9 +1416,49 @@ iavf_dev_uninit(struct rte_eth_dev *dev)
> return 0;
> }
>
>+static int
>+handle_dcf_arg(__rte_unused const char *key, const char *value,
>+ __rte_unused void *arg)
>+{
>+ bool *dcf = arg;
>+
>+ if (arg == NULL || value == NULL)
>+ return -EINVAL;
>+
>+ if (strcmp(value, "dcf") == 0)
>+ *dcf = true;
>+ else
>+ *dcf = false;
>+
>+ return 0;
>+}
>+
>+static bool
>+check_cap_dcf_enable(struct rte_devargs *devargs)
>+{
>+ struct rte_kvargs *kvlist;
>+ bool enable = false;
>+
>+ if (devargs == NULL)
>+ return false;
>+
>+ kvlist = rte_kvargs_parse(devargs->args, NULL);
>+ if (kvlist == NULL)
>+ return false;
>+
>+ rte_kvargs_process(kvlist, "cap", handle_dcf_arg, &enable);
Need error handling for failure case.
>+
>+ rte_kvargs_free(kvlist);
>+
>+ return enable;
>+}
>+
> static int eth_iavf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
> struct rte_pci_device *pci_dev)
> {
>+ if (check_cap_dcf_enable(pci_dev->device.devargs))
>+ return 1; /* continue to probe */
This comment is confusing...
>+
> return rte_eth_dev_pci_generic_probe(pci_dev,
> sizeof(struct iavf_adapter), iavf_dev_init);
> }
>@@ -1439,6 +1479,7 @@ static struct rte_pci_driver rte_iavf_pmd = {
> RTE_PMD_REGISTER_PCI(net_iavf, rte_iavf_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(net_iavf, pci_id_iavf_map);
> RTE_PMD_REGISTER_KMOD_DEP(net_iavf, "* igb_uio | vfio-pci");
>+RTE_PMD_REGISTER_PARAM_STRING(net_iavf, "cap=dcf");
> RTE_INIT(iavf_init_log)
> {
> iavf_logtype_init = rte_log_register("pmd.net.iavf.init");
>--
>2.25.1
>
next prev parent reply other threads:[~2020-03-09 15:40 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:14 [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support Haiyue Wang
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-09 15:38 ` Ye Xiaolong [this message]
2020-03-10 2:19 ` Wang, Haiyue
2020-03-10 3:37 ` Ye Xiaolong
2020-03-10 4:26 ` Wang, Haiyue
2020-03-23 1:50 ` Wu, Jingjing
2020-03-23 1:55 ` Wang, Haiyue
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 2/4] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-09 16:25 ` Ye Xiaolong
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework Haiyue Wang
2020-03-10 4:17 ` Ye Xiaolong
2020-03-10 5:09 ` Wang, Haiyue
2020-03-10 5:23 ` Ye Xiaolong
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 4/4] doc: add release notes for Intel ice PMD Haiyue Wang
2020-03-09 15:22 ` Ye Xiaolong
2020-03-10 2:16 ` Wang, Haiyue
2020-03-09 15:36 ` [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support David Marchand
2020-03-09 16:20 ` Ye Xiaolong
2020-03-09 17:57 ` Thomas Monjalon
2020-03-09 19:34 ` Kevin Traynor
2020-03-10 2:00 ` Wang, Haiyue
2020-03-10 7:48 ` Thomas Monjalon
2020-03-10 9:36 ` Ferruh Yigit
2020-03-10 14:11 ` Aaron Conole
2020-03-10 14:09 ` Aaron Conole
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 0/7] " Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-13 5:27 ` Ye Xiaolong
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability Haiyue Wang
2020-03-13 5:51 ` Ye Xiaolong
2020-03-13 6:19 ` Wang, Haiyue
2020-03-13 6:04 ` Ye Xiaolong
2020-03-13 6:10 ` Wang, Haiyue
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-13 7:59 ` Ye Xiaolong
2020-03-13 8:03 ` Ye Xiaolong
2020-03-16 4:52 ` Wang, Haiyue
2020-03-13 14:06 ` Ye Xiaolong
2020-03-13 14:11 ` Wang, Haiyue
2020-03-10 6:50 ` [dpdk-dev] [PATCH v2 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-13 7:01 ` Ye Xiaolong
2020-03-16 5:58 ` Wang, Haiyue
2020-03-13 16:19 ` [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support Stillwell Jr, Paul M
2020-03-13 16:25 ` Wang, Haiyue
2020-03-13 16:50 ` Stillwell Jr, Paul M
2020-03-13 17:05 ` Wang, Haiyue
2020-03-13 17:47 ` Stillwell Jr, Paul M
2020-03-14 1:57 ` Wang, Haiyue
2020-03-15 1:49 ` Zhang, Qi Z
2020-03-16 18:54 ` Stillwell Jr, Paul M
2020-03-17 2:35 ` Wang, Haiyue
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 " Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-16 5:52 ` [dpdk-dev] [PATCH v3 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-26 3:28 ` Wu, Jingjing
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-26 3:03 ` [dpdk-dev] [PATCH v4 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-26 4:11 ` [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support Zhang, Qi Z
2020-03-26 5:05 ` Ye Xiaolong
2020-03-26 5:26 ` Wang, Haiyue
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 " Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-26 7:15 ` [dpdk-dev] [PATCH v5 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-31 8:50 ` Ferruh Yigit
2020-03-31 12:17 ` Wang, Haiyue
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-27 2:56 ` [dpdk-dev] [PATCH v6 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-27 15:26 ` [dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309153813.GC112283@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).