From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330CFC4CECE for ; Fri, 13 Mar 2020 05:30:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C6631206FA for ; Fri, 13 Mar 2020 05:30:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6631206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E04F81BFBF; Fri, 13 Mar 2020 06:30:33 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2F0061BFA5 for ; Fri, 13 Mar 2020 06:30:31 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 22:30:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,547,1574150400"; d="scan'208";a="237102397" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga008.jf.intel.com with ESMTP; 12 Mar 2020 22:30:28 -0700 Date: Fri, 13 Mar 2020 13:27:51 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com, beilei.xing@intel.com, wei.zhao1@intel.com Message-ID: <20200313052751.GC44839@intel.com> References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200310065029.40966-1-haiyue.wang@intel.com> <20200310065029.40966-2-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310065029.40966-2-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/iavf: stop the PCI probe in DCF mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/10, Haiyue Wang wrote: >A new DCF PMD will be introduced, which runs on Intel VF hardware, and >it is a pure software design to control the advance functionality (such >as switch, ACL) for rest of the VFs. > >So if the DCF (Device Config Function) mode is specified by the devarg >'cap=dcf', then it will stop the PCI probe in the iavf PMD. > >Signed-off-by: Haiyue Wang >--- > drivers/net/iavf/iavf_ethdev.c | 43 ++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > >diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c >index 34913f9c4..c0b95e169 100644 >--- a/drivers/net/iavf/iavf_ethdev.c >+++ b/drivers/net/iavf/iavf_ethdev.c >@@ -1416,9 +1416,51 @@ iavf_dev_uninit(struct rte_eth_dev *dev) > return 0; > } > >+static int >+iavf_dcf_cap_check_handler(__rte_unused const char *key, >+ const char *value, __rte_unused void *opaque) >+{ >+ if (strcmp(value, "dcf")) >+ return -1; >+ >+ return 0; >+} >+ >+static int >+iavf_dcf_cap_selected(struct rte_devargs *devargs) >+{ >+ struct rte_kvargs *kvlist; >+ const char *key = "cap"; >+ int ret = 0; >+ >+ if (devargs == NULL) >+ return 0; >+ >+ kvlist = rte_kvargs_parse(devargs->args, NULL); >+ if (kvlist == NULL) >+ return 0; >+ >+ if (!rte_kvargs_count(kvlist, key)) >+ goto exit; >+ >+ /* dcf capability selected when there's a key-value pair: cap=dcf */ >+ if (rte_kvargs_process(kvlist, key, >+ iavf_dcf_cap_check_handler, NULL) < 0) >+ goto exit; >+ >+ ret = 1; >+ >+exit: >+ rte_kvargs_free(kvlist); >+ return ret; >+} >+ > static int eth_iavf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > struct rte_pci_device *pci_dev) > { >+ if (iavf_dcf_cap_selected(pci_dev->device.devargs)) >+ return 1; >+ > return rte_eth_dev_pci_generic_probe(pci_dev, > sizeof(struct iavf_adapter), iavf_dev_init); > } >@@ -1439,6 +1481,7 @@ static struct rte_pci_driver rte_iavf_pmd = { > RTE_PMD_REGISTER_PCI(net_iavf, rte_iavf_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_iavf, pci_id_iavf_map); > RTE_PMD_REGISTER_KMOD_DEP(net_iavf, "* igb_uio | vfio-pci"); >+RTE_PMD_REGISTER_PARAM_STRING(net_iavf, "cap=dcf"); > RTE_INIT(iavf_init_log) > { > iavf_logtype_init = rte_log_register("pmd.net.iavf.init"); >-- >2.25.1 > Reviewed-by: Xiaolong Ye