From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31252C43331 for ; Mon, 30 Mar 2020 07:40:43 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D9C34206CC for ; Mon, 30 Mar 2020 07:40:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9C34206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFF021BFD4; Mon, 30 Mar 2020 09:40:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 57E9CF12; Mon, 30 Mar 2020 09:40:40 +0200 (CEST) IronPort-SDR: LFMbUPDYEJlnYkzOGtG8zIvU+pvwcVEvvVaZebciJeAyKC6VSw54bskJkhUjFKHmPrd1e9z9Oz NFXbQpApyLmQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 00:40:39 -0700 IronPort-SDR: evHmWgaqLSpO2jWAFPz7bpe+oI3ei4hGbkwgt0ysx5uvotk3QMN0u54+1aY2OzN/VWxfkDfwTT 85zLnFRQvL3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,323,1580803200"; d="scan'208";a="239692053" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga007.fm.intel.com with ESMTP; 30 Mar 2020 00:40:38 -0700 Date: Mon, 30 Mar 2020 15:37:16 +0800 From: Ye Xiaolong To: Wei Zhao Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20200330073716.GF29805@intel.com> References: <1582760662-9263-1-git-send-email-wei.zhao1@intel.com> <20200330063323.5371-1-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330063323.5371-1-wei.zhao1@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix issue for e-tag defination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Wei Thanks for identifying the root cause. On 03/30, Wei Zhao wrote: >An issue has been caused after change definations of bool, >we had better use uint16_t to define e-tag ethertype, not 8 >bits length bool, that patch will change bool bits length, which >introduce a bug for etag/etag_strip for x550 NIC. So change >to the 16 bits defination. > >Cc: stable@dpdk.org >Fixes: ad43b7bce95b ("net/ixgbe: avoid multiple definitions of bool") > >Signed-off-by: Wei Zhao > >v2: >-add more info and find root cause for this issue >--- > drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h >index e1cd8fd16..c5d0e0912 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.h >+++ b/drivers/net/ixgbe/ixgbe_ethdev.h >@@ -358,7 +358,7 @@ struct ixgbe_l2_tn_info { > struct rte_hash *hash_handle; > bool e_tag_en; /* e-tag enabled */ > bool e_tag_fwd_en; /* e-tag based forwarding enabled */ >- bool e_tag_ether_type; /* ether type for e-tag */ >+ uint16_t e_tag_ether_type; /* ether type for e-tag */ > }; > > struct rte_flow { >-- >2.19.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.