From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED35C433E0 for ; Fri, 22 May 2020 06:14:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id BB7952073B for ; Fri, 22 May 2020 06:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB7952073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA2651D8F0; Fri, 22 May 2020 08:14:26 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CA2481D8CC; Fri, 22 May 2020 08:14:24 +0200 (CEST) IronPort-SDR: fXZZbbCHHOEBTk7HAs313QqG0pWup0i/rBEIvve3bq04ZmhcTu0bSMHG0dn3gUgCGb1BR3qM+/ /fk9j8Xkyxgg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 23:14:23 -0700 IronPort-SDR: QJA989n5v/fF/ilJ7X7MaAQWHvawHXVrRvldVX0Wjq5KQM4Mw9VO/RRr0AvRzE+ZrR1jN2WK5X bgjBzdy+n7AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,420,1583222400"; d="scan'208";a="283304365" Received: from dpdk.sh.intel.com ([10.239.255.14]) by orsmga002.jf.intel.com with ESMTP; 21 May 2020 23:14:21 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Zhao1 Wei , Guinan Sun , stable@dpdk.org Date: Fri, 22 May 2020 05:59:55 +0000 Message-Id: <20200522055955.30712-1-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ixgbe: fix MACsec private API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The driver type need to be checked in private API. The patch fixes the issue. Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") Cc: stable@dpdk.org Signed-off-by: Guinan Sun --- drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c index 8bcaded6e..9bff557f9 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c @@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp) dev = &rte_eth_devices[port]; + if (!is_ixgbe_supported(dev)) + return -ENOTSUP; + macsec_setting.offload_en = 1; macsec_setting.encrypt_en = en; macsec_setting.replayprotect_en = rp; @@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port) dev = &rte_eth_devices[port]; + if (!is_ixgbe_supported(dev)) + return -ENOTSUP; + ixgbe_dev_macsec_setting_reset(dev); ixgbe_dev_macsec_register_disable(dev); -- 2.17.1