From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B46D7C433DF for ; Fri, 22 May 2020 15:00:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6BBC1204EF for ; Fri, 22 May 2020 15:00:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BBC1204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A80E11D96F; Fri, 22 May 2020 17:00:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 373C61D969 for ; Fri, 22 May 2020 17:00:34 +0200 (CEST) IronPort-SDR: /McoDOkPsjAzKEiKSuIiuaAlolGlxpZ+Qd+LaWWTvjTbpqCEUTmNSo5qpOKRnkI/ahEUTEZbCd cUcLO2y6fxdg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 08:00:33 -0700 IronPort-SDR: AeKtgMXlJrONaAVnV+/U6iTGuUY7r4dzypEny99NjMQ3UmiVEQ1uBs8Uapc6aJvsv1erAyGC43 Ei/Ob6jPHH7w== X-IronPort-AV: E=Sophos;i="5.73,422,1583222400"; d="scan'208";a="440877656" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.85.183]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 May 2020 08:00:31 -0700 Date: Fri, 22 May 2020 16:00:28 +0100 From: Bruce Richardson To: Ciara Power Cc: kevin.laatz@intel.com, dev@dpdk.org, jerinj@marvell.com, david.marchand@redhat.com, thomas@monjalon.net, keith.wiles@intel.com Message-ID: <20200522150028.GA880@bricha3-MOBL.ger.corp.intel.com> References: <20200522134839.15911-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200522134839.15911-1-ciara.power@intel.com> Subject: Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 22, 2020 at 02:48:39PM +0100, Ciara Power wrote: > Initially, printf was used to indicate and error/warning resulting from > telemetry initialisation. This is now fixed to use EAL logs for > warnings, and the unnecessary printf for an error is removed. > > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency") > Fixes: dd6275a424ac ("telemetry: fix error log output") > Cc: david.marchand@redhat.com > > Signed-off-by: Ciara Power Reviewed-by: Bruce Richardson