From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE50C54E41 for ; Tue, 5 Mar 2024 17:41:19 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE73F40271; Tue, 5 Mar 2024 18:41:18 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 76C3F40270 for ; Tue, 5 Mar 2024 18:41:17 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B267C20B74C0; Tue, 5 Mar 2024 09:41:16 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B267C20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709660476; bh=5EzdQMhmxqCZ9sBNYRlVOPFsq4zldlAtAfRSOarxVgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JEsAAiJ2I88BQ4TNNsYaGptEVRzatiscjYkHSRfD4EApAiY+ybyexMEZpZGK5jOX5 opaJH99pKOVk+c9LzF/ZPpVZq9NRSpPqvMDUebM9HU8mTieGlitloFLezzm9jpNdzf P14DHqHiHfNOrBzbLo2hjDfwZwGIV7yH8cbIIqt0= Date: Tue, 5 Mar 2024 09:41:16 -0800 From: Tyler Retzlaff To: David Marchand Cc: Jerin Jacob , dev@dpdk.org, Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Cristian Dumitrescu , David Christensen , David Hunt , Ferruh Yigit , Honnappa Nagarahalli , Jasvinder Singh , Kevin Laatz , Konstantin Ananyev , Min Zhou , Ruifeng Wang , Sameh Gobriel , Stanislaw Kardach , Thomas Monjalon , Vladimir Medvedkin , Yipeng Wang Subject: Re: [PATCH v7 10/39] eventdev: use C11 alignas Message-ID: <20240305174116.GB18937@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com> <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com> <1709574764-9041-11-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 05, 2024 at 04:47:05PM +0100, David Marchand wrote: > On Mon, Mar 4, 2024 at 6:54 PM Tyler Retzlaff > wrote: > > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > > index 3af4686..08e5f93 100644 > > --- a/lib/eventdev/rte_eventdev.h > > +++ b/lib/eventdev/rte_eventdev.h > > @@ -1338,7 +1338,7 @@ int rte_event_dev_stop_flush_callback_register(uint8_t dev_id, > > /** > > * Event vector structure. > > */ > > -struct rte_event_vector { > > +struct __rte_aligned(16) rte_event_vector { > > uint16_t nb_elem; > > /**< Number of elements valid in this event vector. */ > > uint16_t elem_offset : 12; > > @@ -1376,23 +1376,19 @@ struct rte_event_vector { > > * value to share between dequeue and enqueue operation. > > * The application should not modify this field. > > */ > > - union { > > + union __rte_aligned(16) { > > #endif > > struct rte_mbuf *mbufs[0]; > > void *ptrs[0]; > > uint64_t u64s[0]; > > #ifndef __cplusplus > > - } __rte_aligned(16); > > + }; > > #endif > > /**< Start of the vector array union. Depending upon the event type the > > * vector array can be an array of mbufs or pointers or opaque u64 > > * values. > > */ > > -#ifndef __DOXYGEN__ > > -} __rte_aligned(16); > > -#else > > }; > > -#endif > > This part was a strange construct. > I see nothing wrong with the change (doxygen passes fine), but just a > heads up to Jerin. So there was another series merged recently that added this __DOXYGEN__ conditional I'm just removing it again. Bruce pointed out that one of the benefits of moving __rte_aligned(16) between struct doxygen no longer gets confused. https://mails.dpdk.org/archives/dev/2024-March/289231.html > > > -- > David Marchand