From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB30C5DF60 for ; Fri, 8 Nov 2019 13:26:52 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C5BC420656 for ; Fri, 8 Nov 2019 13:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="CQXb9dXG"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jXM+kcZd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5BC420656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 064911C1AC; Fri, 8 Nov 2019 14:26:51 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id AF5A51C1AB for ; Fri, 8 Nov 2019 14:26:49 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 555036CC6; Fri, 8 Nov 2019 08:26:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 08 Nov 2019 08:26:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qhbxyibCduZQgSMAJcAXqbmrtaLdRXp3s186pFBzgP4=; b=CQXb9dXGtoaZ vFqcrTb3cCllnd4RR/8qI4vZ+XLfs6X36f0gcPsnaCaZuAUlNQSmAOrzPTRbVvNm Q8WQSeyKZSsLy5VYXu+ojItz1p3r9QsvT1zS+PKPnAXp/QKTLWhLY3/jLmXDazcD 6DKVoPho+EzKx+S2U/5p0P4cFTgwgrM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=qhbxyibCduZQgSMAJcAXqbmrtaLdRXp3s186pFBzg P4=; b=jXM+kcZdlSUWiojadhVmp1VZ71oRZjAGE5qsOn41MvIu9ZO0AUEzyGO2A 9ZTq5ArfFmeHZPWIzF1N/J0FP4iYjih811j+YeHaVcZdL5BkVMtmiVn4szmyieVY GJHH79LlDfUl3jqcEdY2GSrnuF03vIDkfLzOevbwZPwlE2vqmhRDCyFA9ebPOAEm Pm7dJRjk2WRW7wOaTE4m7UHjZh+6lHXpRmGFjjuE87A/E4kGv7+aIzBKNwRXI0U/ EvX6iFocFAGnMs2sK3VgEfH1xH56e8z6e0RH2J6w3VbGMw800HrSoY8pmuYjQpDJ HpJFqKcUakFTNlV8iyOzdj8bwVwiw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddvuddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2C628306005B; Fri, 8 Nov 2019 08:26:47 -0500 (EST) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: Ori Kam , Andrew Rybchenko , "dev@dpdk.org" , "pbhagavatula@marvell.com" , "Yigit, Ferruh" , "jerinj@marvell.com" , "Mcnamara, John" , "Kovacevic, Marko" , Adrien Mazarguil , "david.marchand@redhat.com" , "ktraynor@redhat.com" , Olivier Matz Date: Fri, 08 Nov 2019 14:26:46 +0100 Message-ID: <2176859.s4fRIXXLBy@xps> In-Reply-To: <039ED4275CED7440929022BC67E7061153DC66A1@SHSMSX105.ccr.corp.intel.com> References: <20191025152142.12887-1-pbhagavatula@marvell.com> <039ED4275CED7440929022BC67E7061153DC66A1@SHSMSX105.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2019 14:16, Zhang, Qi Z: > From: Ori Kam > > > > Yes missed somehow 6. > > One more general comment, what happened until now? The Mark is already > > implemented and working more then 2 years. > > Actually we get many complain on i40e driver does not support MARK due to vector path is selected by default > The driver always need a hint to select the mark aware data path by "--pkt-filter-mode =perfect" which is just a workaround. > though this issue has been finally solved since software mark on vPMD is enabled recently on i40e. > but For the new ice driver, we didn't get chance to enable this on vPMD yet, then we meet the same issue. Qi, Intel knows the issue for a long time. Did Intel helped with dynamic mbuf (part of the solution)? Did Intel helped with this ethdev change? In general, doing some PMD workaround instead of discussing API change is bad. That's the same story for the VF config via representor, etc. The way Intel was pushing some API which were not generic at all is also bad. I really believe it's time to have truly generic API for all needs. Speaking about that, we need a lot of cleanups in ethdev to remove some vendor-specific bits and find generic replacements. Qi, please don't take it personnaly, I am happy you enter in the discussion, it is a good sign that we can do API improvements during next year. I am motivated to address all ethdev issues before the next LTS 20.11.