From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FAC0C3A59F for ; Sat, 31 Aug 2019 08:04:32 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E5C3F23774 for ; Sat, 31 Aug 2019 08:04:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5C3F23774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E16A1EA2E; Sat, 31 Aug 2019 10:04:29 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 633321EA2D for ; Sat, 31 Aug 2019 10:04:27 +0200 (CEST) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 61A41C2414F98725F863; Sat, 31 Aug 2019 16:04:25 +0800 (CST) Received: from [127.0.0.1] (10.57.115.182) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Sat, 31 Aug 2019 16:04:15 +0800 To: Ferruh Yigit , References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com> <1566568031-45991-12-git-send-email-xavier.huwei@huawei.com> <7497c1f6-4f50-16a0-6114-227fd7dca55d@intel.com> CC: , , , From: "Wei Hu (Xavier)" Message-ID: <218b115d-0949-adf4-aad3-47d2fa88997b@huawei.com> Date: Sat, 31 Aug 2019 16:04:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <7497c1f6-4f50-16a0-6114-227fd7dca55d@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control of hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019/8/30 23:07, Ferruh Yigit wrote: > On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote: >> This patch adds support for MAC PAUSE flow control and priority flow >> control of hns3 PMD driver. All user priorities(up) must be mapped to >> tc0 when MAC PAUSE flow control is enabled. Ups can be mapped to other >> tcs driver permit when PFC is enabled. Flow control function by default >> is turned off to ensure that app startup state is the same each time. > As far as I can see the patch both enable DCB and flow control, can you please > either split the patch or update the commit log to cover both features? Hi, Ferruh Yigit Thanks for your comments. We will modify the commit log in patch V2 as follows: This patch adds support for MAC PAUSE flow control and priority flow control(PFC). MAC PAUSE flow control features: All user priorities(up) are mapped to tc0. It supports settings of flow mode and pause time. DCB features: Up can be mapped to other tc driver permits according to business requirement. We can config DCB information and enable PFC by rte_eth_dev_configure interface. Besides, enabling flow control of a priority is supported by rte_eth_dev_priority_flow_ctrl_set interface. we can also set flow mode and pause time by rte_eth_dev_priority_flow_ctrl_set. we do not support manual setting of ETS, but driver equally distributes bandwidth for each tc according to number of used tc. In addition, flow control function by default is turned off to ensure that app startup state is the same each time. >> Signed-off-by: Huisong Li >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Hao Chen > <...> > >> static const struct eth_dev_ops hns3_eth_dev_ops = { >> .dev_close = hns3_dev_close, >> .mtu_set = hns3_dev_mtu_set, >> .dev_infos_get = hns3_dev_infos_get, >> .fw_version_get = hns3_fw_version_get, >> + .flow_ctrl_get = hns3_flow_ctrl_get, >> + .flow_ctrl_set = hns3_flow_ctrl_set, >> + .priority_flow_ctrl_set = hns3_priority_flow_ctrl_set, > Can you please update .ini file in this patch and mark following features as > supported: > Flow control OK, We will fix it in patch V2. >> .mac_addr_add = hns3_add_mac_addr, >> .mac_addr_remove = hns3_remove_mac_addr, >> .mac_addr_set = hns3_set_default_mac_addr, >> @@ -2753,6 +2949,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { >> .reta_update = hns3_dev_rss_reta_update, >> .reta_query = hns3_dev_rss_reta_query, >> .filter_ctrl = hns3_dev_filter_ctrl, >> + .get_dcb_info = hns3_get_dcb_info, > Can you please update .ini file in this patch and mark following features as > supported: > DCB > OK, We will fix it in patch V2. Regards Xavier