From: Thomas Monjalon <thomas@monjalon.net>
To: Andrius Sirvys <andrius.sirvys@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status
Date: Thu, 08 Aug 2019 09:17:19 +0200 [thread overview]
Message-ID: <2194097.CDRCBNjSrz@xps> (raw)
In-Reply-To: <20190807130458.16754-1-andrius.sirvys@intel.com>
07/08/2019 15:04, Andrius Sirvys:
> The ast.literal_eval() was used incorrectly and wouldn't properly
> retrieve the user option. Was causing the options to keep being listed
> in a loop. Removed and replaced with raw_input() being cast to an int.
> Works as expected now.
You mean you added "ast.literal_eval()" without testing it?
Kevin, that's not the first time I ask,
who is testing this telemetry stuff?
I have the bad feeling this is a toy,
and you send random untested patches for it.
How I can know this patch is seriously tested enough
before merging it at the last minute in 19.08?
> Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> Cc: andrius.sirvys@intel.com
>
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> ---
> v2: Removed unnecessary comments
Please keep all versions in the same email thread by using --in-reply-to
> try:
> - raw_input # Python 2
> + raw_input # Python 2
> except NameError:
> - raw_input = input # Python 3
> + raw_input = input # Python 3
Why changing this indentation?
next prev parent reply other threads:[~2019-08-08 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 13:04 [dpdk-dev] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status Andrius Sirvys
2019-08-08 7:17 ` Thomas Monjalon [this message]
2019-08-08 14:37 ` [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script Andrius Sirvys
2019-08-08 15:32 ` Van Haaren, Harry
2019-08-08 15:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2194097.CDRCBNjSrz@xps \
--to=thomas@monjalon.net \
--cc=andrius.sirvys@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).