From: Kevin Traynor <ktraynor@redhat.com> To: Aaron Conole <aconole@redhat.com>, Harry van Haaren <harry.van.haaren@intel.com>, nikhil.rao@intel.com Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, Gage Eads <gage.eads@intel.com>, Thomas Monjalon <thomas@monjalon.net>, dpdk stable <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v2] service: don't walk out of bounds when checking services Date: Fri, 7 Feb 2020 12:04:12 +0000 Message-ID: <25df28cf-192b-046b-63b3-b8f72a5f434e@redhat.com> (raw) In-Reply-To: <CAJFAV8y7Vt1-EkS+BxUQbKLaqpFygc5djFcxE-wtWAa9R8Sm5A@mail.gmail.com> On 20/12/2019 14:43, David Marchand wrote: > On Wed, Dec 4, 2019 at 9:34 AM David Marchand <david.marchand@redhat.com> wrote: >> >> On Wed, Dec 4, 2019 at 9:33 AM David Marchand <david.marchand@redhat.com> wrote: >>> >>> On Tue, Dec 3, 2019 at 10:15 PM Aaron Conole <aconole@redhat.com> wrote: >>>> >>>> The service_valid call is used without properly bounds checking the >>>> input parameter. Almost all instances of the service_valid call are >>>> inside a for() loop that prevents excessive walks, but some of the >>>> public APIs don't bounds check and will pass invalid arguments. >>>> >>>> Prevent this by using SERVICE_GET_OR_ERR_RET where it makes sense, >>>> and adding a bounds check to one service_valid() use. >>>> >>>> Fixes: 8d39d3e237c2 ("service: fix race in service on app lcore function") >>>> Fixes: e9139a32f6e8 ("service: add function to run on app lcore") >>>> Fixes: e30dd31847d2 ("service: add mechanism for quiescing") >> Cc: stable@dpdk.org >> With the commit below, this patch will apply cleanly on 18.11. Seems ok to me to add below commit, wdyt? commit e484ccddbe1b41886fef1e445ef2fdfa55086198 Author: Nikhil Rao <nikhil.rao@intel.com> Date: Mon Sep 16 15:31:02 2019 +0530 service: avoid false sharing on core state >>>> Signed-off-by: Aaron Conole <aconole@redhat.com> >>> >>> Reviewed-by: David Marchand <david.marchand@redhat.com> > > Applied, thanks. > > > -- > David Marchand >
next prev parent reply index Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-26 14:56 [dpdk-dev] [PATCH] " Aaron Conole 2019-12-02 16:16 ` Eads, Gage 2019-12-02 16:19 ` David Marchand 2019-12-03 15:10 ` Aaron Conole 2019-12-03 21:15 ` [dpdk-dev] [PATCH v2] " Aaron Conole 2019-12-04 8:33 ` David Marchand 2019-12-04 8:34 ` David Marchand 2019-12-20 14:43 ` David Marchand 2020-02-07 12:04 ` Kevin Traynor [this message] 2020-02-07 14:27 ` Aaron Conole 2020-02-14 16:38 ` Kevin Traynor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=25df28cf-192b-046b-63b3-b8f72a5f434e@redhat.com \ --to=ktraynor@redhat.com \ --cc=aconole@redhat.com \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=gage.eads@intel.com \ --cc=harry.van.haaren@intel.com \ --cc=nikhil.rao@intel.com \ --cc=pbhagavatula@marvell.com \ --cc=stable@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git