From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EAF6C2BA2B for ; Fri, 10 Apr 2020 15:11:22 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C4E732082D for ; Fri, 10 Apr 2020 15:11:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="f+nP20Ls"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="0YT3S6h4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4E732082D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90E471C1A8; Fri, 10 Apr 2020 17:11:20 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D3CC21C114 for ; Fri, 10 Apr 2020 17:11:18 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 34EFE5C009A; Fri, 10 Apr 2020 11:11:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 10 Apr 2020 11:11:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4jJLV3vG/vfLdgQGZsKHQbU42hTLfiberGae2rwPz6k=; b=f+nP20LsZ4h1 0OGPOQeVVYVWmegykyavFkx6cR877bG0/EnepSU/KMQGDUB/MbLQX0NXJX37obd8 q55LKz2k8l5tJaS53VaYAZ/ihqz4mmV9Sh94WbpW1YjwZn2uuoKMCRxcjd0sXGyp abn9rY7TAsIW98+adk9T0coCxowbBvg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4jJLV3vG/vfLdgQGZsKHQbU42hTLfiberGae2rwPz 6k=; b=0YT3S6h4G+M1KDUbJB0UNLF6WTZbV33WvBL5rNJbN5zWSwFu88eX96sPa XQybNgDtwYSEXoxxSgjHomuwjPPUc3aUDn5bPaBQKUt2lqwchStfCaRm48NK/66K TBcct06AGE2TNfI8ImGNqASLEI1BEBAXGG1ZAH3sW/8IIhW20KS5SIjqdDDk+atT 7ou079loobawVh22GNK9ieESPNXA6mujUExRyNCoXD88mrLPgfdZoGYEmMPnqHMa l6V0WXJR5daXGSb7M+WVaFwJ7j271YJosMf1F04LYn2Iw5nPfvRr92LNSMhPdmnQ m8KWEVIUIU8lJ+U2u+GdaIcrb3AVQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvddvgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4CC13280059; Fri, 10 Apr 2020 11:11:15 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , David Marchand Cc: Jerin Jacob , dpdk-dev , "Richardson, Bruce" , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Sunil Kumar Kori , Olivier Matz Date: Fri, 10 Apr 2020 17:11:14 +0200 Message-ID: <2919279.ktpJ11cQ8Q@thomas> In-Reply-To: References: <20200329144342.1543749-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2020 17:00, David Marchand: > On Fri, Apr 10, 2020 at 4:38 PM Jerin Jacob wrote: > > > - Another comment, on the form, I can see that we talk about dataplane > > > tracepoints and fastpath API. > > > Is there a difference? or could everything be named in a consistent > > > > No. Both are the same. > > > > > way (the headers would have to be aligned too)? > > > > Personally I like the fast path. The log calls it as DP( see RTE_LOG_DP). > > In order to have consistency, I will pick the DP and change it everywhere to DP, > > and header files to xxxxx_dp.h from xxxx_fp.h. > > I too have a preference for "fast path". > Thomas ? OK for fp.