From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 880FBC4CEC8 for ; Fri, 13 Sep 2019 18:31:12 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 11D6D2054F for ; Fri, 13 Sep 2019 18:31:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11D6D2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=solarflare.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96EFE2B8E; Fri, 13 Sep 2019 20:31:10 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 3DAD21BE0 for ; Fri, 13 Sep 2019 20:31:09 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 1CBAB4C0072; Fri, 13 Sep 2019 18:31:07 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Sep 2019 19:30:54 +0100 To: Ferruh Yigit , Nicolas Chautru , Chas Williams , David Hunt , Harry van Haaren , "Marko Kovacevic" , Ori Kam , "Bruce Richardson" , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Bernard Iremonger , Konstantin Ananyev , Cristian Dumitrescu , Declan Doherty , Anatoly Burakov , Reshma Pattan , John McNamara , "Xiaoyun Li" , Jasvinder Singh , "Byron Marohn" , Maxime Coquelin , Tiwei Bie , Zhihong Wang CC: , Ivan Ilchenko References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-14-git-send-email-arybchenko@solarflare.com> <61bc58e1-8c25-57f9-8374-e5a3005a97f3@intel.com> From: Andrew Rybchenko Message-ID: <29b06913-8239-1065-43b8-192d64bd5e00@solarflare.com> Date: Fri, 13 Sep 2019 21:30:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <61bc58e1-8c25-57f9-8374-e5a3005a97f3@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24908.002 X-TM-AS-Result: No-4.729000-8.000000-10 X-TMASE-MatchedRID: nVQUmLJJeyZS/GBmiVjsn/ZvT2zYoYOwC/ExpXrHizzHoLp1yJ83GOBw lzWEEXt21bNT+YxZ+GB3aWU5jdY62BLH44aOJ2HsPwKTD1v8YV5KgIbix5+XxFeIuu+Gkot8XKZ G/c1COwSTIGXbawTUhPZRAv723FfbHrHr29AlVGs1VHP4fCovglAGvCQ4hMt8myiLZetSf8my5/ tFZu9S3Ku6xVHLhqfxWBd6ltyXuvuSvpWQPtVgbBUweU9dgkVvYuirdFB5jvzcGmiGhUXs16IH0 hy+C/whUmaTpYQYxIo9uL1uM2iy6+a0KU+CAtwY8FQMnf1/QNrwHX5+Q8jjw1wuriZ3P6dErIJZ JbQfMXRqaM5LmpUkwzunJXJz8X1QftwZ3X11IV0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.729000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24908.002 X-MDID: 1568399468-V_igH7iUqntn Subject: Re: [dpdk-dev] [PATCH v2 13/13] examples: take promiscuous mode switch result into account X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/19 7:40 PM, Ferruh Yigit wrote: > On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return >> value was changed from void to int, so this patch modify usage >> of these functions across examples according to new return type. >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko > <...> > >> diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c >> index 0f48ae926c..a3a7478296 100644 >> --- a/examples/vm_power_manager/main.c >> +++ b/examples/vm_power_manager/main.c >> @@ -121,7 +121,9 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool) >> addr.addr_bytes[4], addr.addr_bytes[5]); >> >> /* Enable RX in promiscuous mode for the Ethernet device. */ >> - rte_eth_promiscuous_enable(port); >> + retval = rte_eth_promiscuous_enable(port); >> + if (ret != 0) >> + return retval; > s/ret/retval > > error: ‘ret’ undeclared (first use in this function) Thanks, unfortunately it was not build by ./devtools/test-build.sh since libvirt-dev package was not installed.