From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7AD4C48BD6 for ; Wed, 26 Jun 2019 12:50:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 794A62147A for ; Wed, 26 Jun 2019 12:50:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 794A62147A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92D1F2BA5; Wed, 26 Jun 2019 14:50:23 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 44601271; Wed, 26 Jun 2019 14:50:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 05:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,419,1557212400"; d="scan'208";a="155857066" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by orsmga008.jf.intel.com with ESMTP; 26 Jun 2019 05:50:18 -0700 To: David Marchand Cc: dev , Bruce Richardson , dpdk stable , Arnon Warshavsky References: <0fdd08d79feb1b60c304a1194d14282238cb679e.1561477829.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <2ae15fb7-e092-21ca-a0d5-16a3cb00e622@intel.com> Date: Wed, 26 Jun 2019 13:50:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal/freebsd: add config reattach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26-Jun-19 1:21 PM, David Marchand wrote: > On Wed, Jun 26, 2019 at 2:03 PM David Marchand > wrote: > >> >> >> On Tue, Jun 25, 2019 at 5:51 PM Anatoly Burakov >> wrote: >> >>> Linux EAL will attach the shared config at an arbitrary address, >>> find out where the shared config is mapped in the primary, and >>> then will reattach it at that exact address. >>> >>> FreeBSD version doesn't seem to go for that extra reattach step, >>> which makes one wonder how did it ever work in the first place. >>> >>> Fix the FreeBSD init to also reattach shared config to the exact >>> same place the primary process has it. >>> >>> Fixes: 764bf26873b9 ("add FreeBSD support") >>> Cc: bruce.richardson@intel.com >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Anatoly Burakov >>> --- <...> > Not sure you noticed, but Arnon also had sent a patch touching the config > mapping parts. > http://patchwork.dpdk.org/patch/54583/ > Yes, i've seen those, didn't get a chance to look at them yet. I'll rebase when necessary. -- Thanks, Anatoly