From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C827C2D0DB for ; Mon, 27 Jan 2020 22:55:49 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9B0BF2087F for ; Mon, 27 Jan 2020 22:55:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="Hrw/JXZ2"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="EeAkje8T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B0BF2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 848A81BFF0; Mon, 27 Jan 2020 23:55:47 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 62BFF1BFB5 for ; Mon, 27 Jan 2020 23:55:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 02F7022125; Mon, 27 Jan 2020 17:55:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 27 Jan 2020 17:55:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=wNYOWDwpwnrUKq//hEGZqoYnkuvYYJrPb9tKXW1TWYU=; b=Hrw/JXZ2Z78f VVYhjIkCmn9weoVmVhD6PIkRZBF5CRmpuL1irtHq1BhL1jwWTCwtz3ICh+03iRtY 8FKkAoc1I3VBN7IAwQwbAFk5P7X7eN4wV3BbuniGHedYrCj+Cx0BnKM9s6XUJrYM uqmSRMQL6Ci57GCSguPMJcp6eC5pU5o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wNYOWDwpwnrUKq//hEGZqoYnkuvYYJrPb9tKXW1TW YU=; b=EeAkje8TKQApjlrfeer1h7xw0eSZBV0qmqWajF959Q31SdDMrj9YX715e awmJ9kGXcEB8J16kVxgPl2zwajIRx3HOUsB1tLIrCyTL1sfHQtum3YyALGW54Bk8 8ImAYudv2NcccSW1p9kypLZZVoFBOgURxR3hiSg2jsJ3gs2LTsJT8iWrBQSitzpt PYWuTAu6hUJDVYtn9zedGk9yu/ASMbLQhBQrLmMPOYsjUvLktmme8OHnKCoUNG4J dOTXzqjNorCJLp3nYDuf4aA5Ahk9nc5u93I3yhWHoY9X60/OSEf90Z9dHe3NX1N0 NGWz44fZrparJOSTrq2sDNYn9ppWQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeefgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 85649306A2CF; Mon, 27 Jan 2020 17:55:44 -0500 (EST) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com, antara.ganesh.kolar@intel.com, stephen@networkplumber.org Date: Mon, 27 Jan 2020 23:55:43 +0100 Message-ID: <3035070.44csPzL39Z@xps> In-Reply-To: <20200113215534.10084-9-pallavi.kadam@intel.com> References: <20200109031312.6344-1-pallavi.kadam@intel.com> <20200113215534.10084-1-pallavi.kadam@intel.com> <20200113215534.10084-9-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 8/9] build: add additional common files support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/01/2020 22:55, Pallavi Kadam: > Added support for additional common files in meson build > to expand Windows EAL and to support the lcore parsing > feature on Windows. > > Signed-off-by: Pallavi Kadam > Signed-off-by: Antara Ganesh Kolar > Reviewed-by: Ranjit Menon > Reviewed-by: Keith Wiles > --- > --- a/lib/librte_eal/windows/eal/meson.build > +++ b/lib/librte_eal/windows/eal/meson.build > common_sources = files( > + '../../common/eal_common_bus.c', > + '../../common/eal_common_class.c', > + '../../common/eal_common_devargs.c', > '../../common/eal_common_errno.c', > '../../common/eal_common_launch.c', > '../../common/eal_common_lcore.c', > - '../../common/eal_common_log.c' > + '../../common/eal_common_log.c', > + '../../common/eal_common_options.c', > + '../../common/eal_common_thread.c', > + '../../common/rte_option.c' Please add a comma after the last item of the list, so the next patch won't need to change this line.