From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields
Date: Sat, 10 Aug 2019 23:40:48 +0200 [thread overview]
Message-ID: <3080600.NuWCTeAXad@xps> (raw)
In-Reply-To: <c889b745-5295-66a6-9a8f-67ba98bd222a@solarflare.com>
06/08/2019 17:27, Andrew Rybchenko:
> On 8/6/19 5:56 PM, Matan Azrad wrote:
> > It may be needed by the user to limit the LRO session packet size.
> > In order to allow the above limitation, a new Rx configuration may be
> > added for the maximum LRO session size.
> >
> > A new capability may be added too to expose the maximum LRO session size
> > supported by the port.
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
> > ---
> > +* ethdev: new 32-bit fields may be added for maximum LRO session size, in
> > + struct ``rte_eth_dev_info`` for the port capability and in struct
> > + ``rte_eth_rxmode`` for the port configuration.
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> I don't know examples when the information is required, but can imagine.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
We have only 2 acks but as they are simple new fields,
better to announce their addition in advance and allow for more
discussion during 19.11 release cycle.
Applied (only patch 1 of 2)
prev parent reply other threads:[~2019-08-10 21:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 14:56 [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields Matan Azrad
2019-08-06 14:56 ` [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO Matan Azrad
2019-08-06 15:58 ` Ananyev, Konstantin
2019-08-06 18:50 ` Matan Azrad
2019-08-07 10:17 ` Ananyev, Konstantin
2019-08-07 12:35 ` Matan Azrad
2019-08-07 14:18 ` Ananyev, Konstantin
2019-08-08 10:16 ` Matan Azrad
2019-08-08 10:48 ` Ananyev, Konstantin
2019-08-08 11:16 ` Matan Azrad
2019-08-08 16:26 ` Ananyev, Konstantin
2019-08-06 18:17 ` Andrew Rybchenko
2019-08-10 21:31 ` Thomas Monjalon
2020-05-24 23:41 ` Thomas Monjalon
2020-06-02 6:49 ` Matan Azrad
2020-07-27 8:00 ` Olivier Matz
2020-07-27 8:41 ` Matan Azrad
2020-07-27 9:07 ` Olivier Matz
2023-06-12 16:38 ` Stephen Hemminger
2019-08-06 15:27 ` [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields Andrew Rybchenko
2019-08-10 21:40 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3080600.NuWCTeAXad@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@mellanox.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).