From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262ADC2BA83 for ; Sun, 16 Feb 2020 11:13:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9D79B20857 for ; Sun, 16 Feb 2020 11:13:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="hh4OTDaS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="qrKX2Ll1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D79B20857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC4C61B952; Sun, 16 Feb 2020 12:13:35 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id DCD202C4F for ; Sun, 16 Feb 2020 12:13:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A346A622; Sun, 16 Feb 2020 06:13:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 16 Feb 2020 06:13:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=uTCdA+WERzgNDFav/qWe8cD4fWYleKUnCGczB2Fk534=; b=hh4OTDaSZpBk kPXxz3c1w6ehzYt1XIOaaaWK9JY/sqWxTBWW7QEXLaHG9tFg6cFLKRgQX7XSCLyp wqJyUQSQZbwL3T1F2G8NxkwLWFKDt1fRet/iDxa6KDPOkyBPXLsCHjGvFIiQh7lg X90WESoYLwRsVK2wkmI+iLTeAM93yDo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uTCdA+WERzgNDFav/qWe8cD4fWYleKUnCGczB2Fk5 34=; b=qrKX2Ll1x9/9RmRAAIDUU+Qxc3pJG/ZUfdqlPEoSRkB+mywxsf3w51xXp PLo8ASDzHyFSDaMCmzAONfdT0ZjFsGqb0qRsF+fika3UcX9sUsgSw4x/neBgR8oS WkdllyB1OIaowkYiFZkNnrsmLDFoGfWwhP840UQIdjNiYX68nkyr2XhtP+WjrVd0 H+Ov8EXQkVHyiAuA3zZ+5LDJLt2lQQzUeKJgTBAFoGUC61klEUuYtWFavw6sdXAD xkWWQzAIGLgibTsb32+1WOCqRrsHa6V7Bdhs5LxZplXSficnwS8Y0eC4KNKRPYHy q7BvcF1lDSL0YZNTdPnas6YE8Asig== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeggddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7ECA53280059; Sun, 16 Feb 2020 06:13:30 -0500 (EST) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com Date: Sun, 16 Feb 2020 12:13:29 +0100 Message-ID: <3090513.CAdn2TfLgq@xps> In-Reply-To: <20200107091343.22965-1-david.hunt@intel.com> References: <20200107091343.22965-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] doc: rework vm power manager user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/01/2020 10:13, David Hunt: > Review and re-work of vm_power_manager documentation. Hopefully this > is clearer, easier to follow. > > Signed-off-by: David Hunt checkpatch is reporting a typo done several times: s/virutal/virtual/ > --- > .../img/vm_power_mgr_highlevel.svg | 2189 +++++++++++------ This high-level diagram is nice but I disagree about having text blocks. I think images should be image-only and the text can be in .rst. It will be easier to update. Thanks > .../img/vm_power_mgr_vm_request_seq.svg | 1455 +++++------ > .../sample_app_ug/vm_power_management.rst | 1194 +++++---- > 3 files changed, 2775 insertions(+), 2063 deletions(-)