DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: Xiao Zhang <xiao.zhang@intel.com>,
	dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com,
	ian.stokes@intel.com, stable@dpdk.org,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Xiaolong Ye <xiaolong.ye@intel.com>
Subject: Re: [dpdk-dev] [v3] net/i40e: fix vlan packets drop
Date: Fri, 08 Nov 2019 20:49:18 +0100
Message-ID: <3103941.IzeQdVNKZZ@xps> (raw)
In-Reply-To: <39c0da13-5bd4-8dd2-ac09-a6ef5c1e3380@redhat.com>

08/11/2019 20:28, Kevin Traynor:
> Hi Xiao,
> 
> On 29/10/2019 05:12, Xiao Zhang wrote:
> > VLAN packets with ip length bigger than 1496 will not be received by
> > i40e/i40evf due to wrong packets size checking. This patch fixes the
> > issue by correcting the maximum frame size during checking.
> > 
> > Fixes: 43e5488c0ac6 ("net/i40e: support MTU configuration")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> > ---
> > v3
> > Checking more places using max packet len.
> > v2
> > Add fix for i40evf and correct the checking when using the max_pkt_len.
> > ---
> >  drivers/net/i40e/i40e_ethdev.c    |  2 +-
> >  drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++----
> >  drivers/net/i40e/i40e_fdir.c      |  2 +-
> >  drivers/net/i40e/i40e_rxtx.c      |  9 ++++++---
> >  lib/librte_ethdev/rte_ethdev.c    | 10 ++++++++--
> >  lib/librte_net/rte_ether.h        |  1 +
> >  6 files changed, 24 insertions(+), 11 deletions(-)
> > 
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > @@ -1257,11 +1257,17 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
> >  			goto rollback;
> >  		}
> >  	} else {
> > +		/**
> > +		 * The overhead from MTU to max frame size.
> > +		 * Considering VLAN and QinQ packet, the VLAN tag size
> > +		 * needs to be added to RTE_ETHER_MAX_LEN.
> > +		 */
> >  		if (dev_conf->rxmode.max_rx_pkt_len < RTE_ETHER_MIN_LEN ||
> > -			dev_conf->rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN)
> > +			dev_conf->rxmode.max_rx_pkt_len > RTE_ETHER_MAX_LEN
> > +				+ RTE_ETHER_VLAN_LEN * 2)
> >  			/* Use default value */
> >  			dev->data->dev_conf.rxmode.max_rx_pkt_len =
> > -							RTE_ETHER_MAX_LEN;
> > +				RTE_ETHER_MAX_LEN + RTE_ETHER_VLAN_LEN * 2;
> 
> +cc ethdev maintainers
> 
> This looks ok to me for i40e case, but I don't know if there is a
> consequence for other PMDs. It seems late to change this, so maybe you
> can live without this part for now.
> 
> Even on the i40e parts, there can be some subtle bug and I requested
> i40e maintainers to review carefully but it has not happened, so for me
> it shouldn't be merged at present.

I would nack for another, simpler, reason:
No ethdev behaviour change should be submitted if title does not start
with "ethdev:" and if ethdev maintainers are not Cc'ed.




  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14  7:53 [dpdk-dev] " Xiao Zhang
2019-10-14 17:41 ` Kevin Traynor
2019-10-15  1:41   ` Zhang, Xiao
2019-10-21  2:44 ` [dpdk-dev] [v2] " Xiao Zhang
2019-10-21 20:15   ` Kevin Traynor
2019-10-29  5:12 ` [dpdk-dev] [v3] " Xiao Zhang
2019-11-08 19:28   ` Kevin Traynor
2019-11-08 19:49     ` Thomas Monjalon [this message]
2019-11-09  3:01       ` Zhang, Qi Z

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3103941.IzeQdVNKZZ@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ian.stokes@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiao.zhang@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git