From: Maxime Coquelin <maxime.coquelin@redhat.com> To: "Yu, Jin" <jin.yu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "Liu, Changpeng" <changpeng.liu@intel.com>, "Bie, Tiwei" <tiwei.bie@intel.com>, "Wang, Zhihong" <zhihong.wang@intel.com>, Lin Li <lilin24@baidu.com>, Xun Ni <nixun@baidu.com>, Yu Zhang <zhangyu31@baidu.com> Subject: Re: [dpdk-dev] [PATCH v6 05/10] vhost: checkout and cleanup the resubmit inflight information Date: Wed, 11 Sep 2019 10:43:31 +0200 Message-ID: <32ea439d-cc3d-9dc1-7a01-b074993c26c6@redhat.com> (raw) In-Reply-To: <B9FBC361811A3D4DBB02350807E29F7B0B957A83@SHSMSX101.ccr.corp.intel.com> On 9/11/19 4:50 AM, Yu, Jin wrote: >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Monday, September 9, 2019 6:21 PM >> To: Yu, Jin <jin.yu@intel.com>; dev@dpdk.org >> Cc: Liu, Changpeng <changpeng.liu@intel.com>; Bie, Tiwei >> <tiwei.bie@intel.com>; Wang, Zhihong <zhihong.wang@intel.com>; Lin Li >> <lilin24@baidu.com>; Xun Ni <nixun@baidu.com>; Yu Zhang >> <zhangyu31@baidu.com> >> Subject: Re: [PATCH v6 05/10] vhost: checkout and cleanup the resubmit inflight >> information >> >> >> >> On 8/29/19 4:12 PM, JinYu wrote: >>> This patch shows how to checkout the inflight ring and construct the >>> resubmit information also include destroying resubmit info. >>> >>> Signed-off-by: Lin Li <lilin24@baidu.com> >>> Signed-off-by: Xun Ni <nixun@baidu.com> >>> Signed-off-by: Yu Zhang <zhangyu31@baidu.com> >>> Signed-off-by: Jin Yu <jin.yu@intel.com> >>> --- >>> lib/librte_vhost/rte_vhost.h | 19 ++++ >>> lib/librte_vhost/vhost.c | 29 ++++- >>> lib/librte_vhost/vhost.h | 9 ++ >>> lib/librte_vhost/vhost_user.c | 197 >>> ++++++++++++++++++++++++++++++++++ >>> 4 files changed, 253 insertions(+), 1 deletion(-) >>> >> ... >>> +static int >>> +vhost_check_queue_inflights_packed(struct virtio_net *dev, >>> + struct vhost_virtqueue *vq) >>> +{ >>> + uint16_t i = 0; >>> + uint16_t resubmit_num = 0, old_used_idx, num; >>> + struct rte_vhost_resubmit_info *resubmit = NULL; >>> + struct inflight_info_packed *inflight_packed; >>> + >>> + if (!(dev->protocol_features & >>> + (1ULL << VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD))) >>> + return RTE_VHOST_MSG_RESULT_OK; >>> + >>> + if (!vq->inflight_packed->version) { >>> + vq->inflight_packed->version = INFLIGHT_VERSION; >>> + return RTE_VHOST_MSG_RESULT_OK; >>> + } >>> + >>> + if ((!vq->inflight_packed)) >>> + return RTE_VHOST_MSG_RESULT_ERR; >> >> It needs to be checked before before being dereferenced. > Sorry I don't understand, you means I should check the vq pointer? No, I meant vq->inflight_packed should be checked earlier, before if (!vq->inflight_packed->version) { >>> + >>> + inflight_packed = vq->inflight_packed; >>> + vq->resubmit_inflight = NULL; >>> + vq->global_counter = 0; >>> + old_used_idx = inflight_packed->old_used_idx; >>> + >>> + if (inflight_packed->used_idx != old_used_idx) { >>> + if (inflight_packed->desc[old_used_idx].inflight == 0) { >>> + inflight_packed->old_used_idx = >>> + inflight_packed->used_idx; >>> + inflight_packed->old_used_wrap_counter = >>> + inflight_packed->used_wrap_counter; >>> + inflight_packed->old_free_head = >>> + inflight_packed->free_head; >>> + } else { >>> + inflight_packed->used_idx = >>> + inflight_packed->old_used_idx; >>> + inflight_packed->used_wrap_counter = >>> + inflight_packed->old_used_wrap_counter; >>> + inflight_packed->free_head = >>> + inflight_packed->old_free_head; >>> + } >>> + } >>> + >>> + for (i = 0; i < inflight_packed->desc_num; i++) { >>> + if (inflight_packed->desc[i].inflight == 1) >>> + resubmit_num++; >>> + } >>> + >>> + if (resubmit_num) { >>> + resubmit = calloc(1, sizeof(struct rte_vhost_resubmit_info)); >>> + if (resubmit == NULL) { >>> + RTE_LOG(ERR, VHOST_CONFIG, >>> + "Failed to allocate memory for resubmit info.\n"); >>> + return RTE_VHOST_MSG_RESULT_ERR; >>> + } >>> + >>> + resubmit->resubmit_list = calloc(resubmit_num, >>> + sizeof(struct rte_vhost_resubmit_desc)); >>> + if (resubmit->resubmit_list == NULL) { >>> + RTE_LOG(ERR, VHOST_CONFIG, >>> + "Failed to allocate memory for resubmit desc.\n"); >>> + return RTE_VHOST_MSG_RESULT_ERR; >>> + } >>> + >>> + num = 0; >>> + for (i = 0; i < inflight_packed->desc_num; i++) { >>> + if (vq->inflight_packed->desc[i].inflight == 1) { >>> + resubmit->resubmit_list[num].index = i; >>> + resubmit->resubmit_list[num].counter = >>> + inflight_packed->desc[i].counter; >>> + num++; >>> + } >>> + } >>> + resubmit->resubmit_num = num; >>> + >>> + if (resubmit->resubmit_num > 1) >>> + qsort(resubmit->resubmit_list, resubmit- >>> resubmit_num, >>> + sizeof(struct rte_vhost_resubmit_desc), >>> + resubmit_desc_compare); >>> + >>> + vq->global_counter = resubmit->resubmit_list[0].counter + 1; >>> + vq->resubmit_inflight = resubmit; >>> + } >>> + >>> + return RTE_VHOST_MSG_RESULT_OK; >>> +} >
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20190806182500.22320> 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 00/10] vhost: support inflight share memory protocol feature JinYu 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 01/10] vhost: add the inflight description JinYu 2019-09-06 16:37 ` Maxime Coquelin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 02/10] vhost: add packed ring JinYu 2019-09-06 16:42 ` Maxime Coquelin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 03/10] vhost: add the inflight structure JinYu 2019-09-06 16:45 ` Maxime Coquelin 2019-09-09 3:04 ` Yu, Jin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 04/10] vhost: add two new messages to support a shared buffer JinYu 2019-09-06 17:22 ` Maxime Coquelin 2019-09-09 3:06 ` Yu, Jin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 05/10] vhost: checkout and cleanup the resubmit inflight information JinYu 2019-09-09 10:20 ` Maxime Coquelin 2019-09-11 2:50 ` Yu, Jin 2019-09-11 8:43 ` Maxime Coquelin [this message] 2019-09-11 9:07 ` Yu, Jin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 06/10] vhost: add the APIs to operate inflight ring JinYu 2019-09-11 13:19 ` Kevin Traynor 2019-09-12 9:26 ` Maxime Coquelin 2019-09-16 1:21 ` Yu, Jin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 07/10] vhost: add APIs for user getting " JinYu 2019-09-12 9:28 ` Maxime Coquelin 2019-09-16 1:20 ` Yu, Jin 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 08/10] vhost: fix vring functions to support packed ring JinYu 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 09/10] vhost: add an API for judging vq format JinYu 2019-08-29 14:12 ` [dpdk-dev] [PATCH v6 10/10] vhost: add vhost-user-blk example which support inflight JinYu 2019-08-30 6:07 ` [dpdk-dev] [PATCH v6 00/10] vhost: support inflight share memory protocol feature Gavin Hu (Arm Technology China) 2019-09-06 16:35 ` Maxime Coquelin 2019-09-09 4:51 ` Yu, Jin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=32ea439d-cc3d-9dc1-7a01-b074993c26c6@redhat.com \ --to=maxime.coquelin@redhat.com \ --cc=changpeng.liu@intel.com \ --cc=dev@dpdk.org \ --cc=jin.yu@intel.com \ --cc=lilin24@baidu.com \ --cc=nixun@baidu.com \ --cc=tiwei.bie@intel.com \ --cc=zhangyu31@baidu.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git