From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA85C04AB6 for ; Mon, 3 Jun 2019 08:52:54 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 40D1427DD1 for ; Mon, 3 Jun 2019 08:52:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40D1427DD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D53B1B995; Mon, 3 Jun 2019 10:52:51 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4DDD61B944; Mon, 3 Jun 2019 10:52:49 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92D49307D861; Mon, 3 Jun 2019 08:52:48 +0000 (UTC) Received: from [10.36.116.210] (ovpn-116-210.ams2.redhat.com [10.36.116.210]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C37219C69; Mon, 3 Jun 2019 08:52:47 +0000 (UTC) From: "Eelco Chaudron" To: "David Marchand" Cc: dev@dpdk.org, stable@dpdk.org, "Qiming Yang" , "Wenzhuo Lu" Date: Mon, 03 Jun 2019 10:52:47 +0200 Message-ID: <356C41E4-5A51-4013-AB44-F48DC74740F7@redhat.com> In-Reply-To: <1559550688-9290-2-git-send-email-david.marchand@redhat.com> References: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> <1559550688-9290-2-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 03 Jun 2019 08:52:48 +0000 (UTC) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/ice: fix dropped packets statistics name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Looks good to me… Acked-by: Eelco Chaudron On 3 Jun 2019, at 10:31, David Marchand wrote: > Copy/paste from i40e, let's align with the fix on i40e. > > Fixes: a37bde56314d ("net/ice: support statistics") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/ice/ice_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index bdbceb4..6cd1c74 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -153,13 +153,13 @@ struct ice_xstats_name_off { > {"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)}, > {"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)}, > {"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)}, > - {"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)}, > + {"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)}, > {"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats, > rx_unknown_protocol)}, > {"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)}, > {"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)}, > {"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)}, > - {"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)}, > + {"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)}, > }; > > #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \ > -- > 1.8.3.1