From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAC9C282DD for ; Thu, 23 May 2019 18:26:00 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 7DA8D2075E for ; Thu, 23 May 2019 18:26:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DA8D2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A53C5689; Thu, 23 May 2019 20:25:59 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C816AA3 for ; Thu, 23 May 2019 20:25:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2019 11:25:56 -0700 X-ExtLoop1: 1 Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga006.jf.intel.com with ESMTP; 23 May 2019 11:25:56 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 23 May 2019 11:25:56 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.79]) by ORSMSX161.amr.corp.intel.com ([169.254.4.187]) with mapi id 14.03.0415.000; Thu, 23 May 2019 11:25:56 -0700 From: "Ergin, Mesut A" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance Thread-Index: AQHVC5/V/P93M9SWj0u3LqZdFjBAbaZ3lZyAgAF8XSA= Date: Thu, 23 May 2019 18:25:55 +0000 Message-ID: <3615B82CA151CF42A86EDDD9846A8B38C7A8C3E5@ORSMSX112.amr.corp.intel.com> References: <1557980885-183777-1-git-send-email-mesut.a.ergin@intel.com> <1557980885-183777-4-git-send-email-mesut.a.ergin@intel.com> <039ED4275CED7440929022BC67E7061153385EC0@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153385EC0@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmYwMjViZjktNzEyNS00MGExLTkxYTEtYmJmZGE1ZTNjYWJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFYzanh6WFkyRTY5bmV5QVh3WGVnQVFwZGdFTGpFSml1a0c3WGJHOUdTZWRrMnJ6XC9tbEp5T25PalNLZWFJMjUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 22, 2019 5:42 AM > To: Ergin, Mesut A ; Xing, Beilei > > Cc: dev@dpdk.org > Subject: RE: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX > allowance >=20 > Hi Mesut: >=20 > > -----Original Message----- > > From: Ergin, Mesut A > > Sent: Thursday, May 16, 2019 12:28 PM > > To: Xing, Beilei ; Zhang, Qi Z > > Cc: dev@dpdk.org; Ergin, Mesut A > > Subject: [PATCH 3/3] net/i40e: fix inadvertent override of vector RX al= lowance > > > > When i40e_rx_vec_dev_conf_condition_check_default() determines whether > > vector receive functions would be allowed during initialization phase, = it should > > honor previously recorded disallowance during configuration phase, and = not > > override simply because it is for the first queue. > > > > Signed-off-by: Mesut Ali Ergin > > --- > > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > > b/drivers/net/i40e/i40e_rxtx_vec_common.h > > index 0e6ffa0..f30cab4 100644 > > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > > @@ -212,6 +212,10 @@ > > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > > if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) > > return -1; > > > > + /* Should not override if vector was already disallowed */ >=20 > It is possible a device be reconfigured between dev_stop/dev_start, vecto= r > mode may fit for the new configure, so the old rx_vec_allowd should be > ignored, >=20 i40e_dev_configure would reset rx_vec_allowed already. Am I missing=20 another reconfiguration path? Mesut > Regards > Qi >=20 > > + if (!ad->rx_vec_allowed) > > + return -1; > > + > > /** > > * Vector mode is allowed only when number of Rx queue > > * descriptor is power of 2. > > -- > > 2.7.4