From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BE4C432C0 for ; Thu, 21 Nov 2019 22:01:30 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8ACF52068E for ; Thu, 21 Nov 2019 22:01:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="X4AsilFh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="EY44rum/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ACF52068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D8B02BA3; Thu, 21 Nov 2019 23:01:28 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 57D1E237 for ; Thu, 21 Nov 2019 23:01:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E54B22703; Thu, 21 Nov 2019 17:01:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 21 Nov 2019 17:01:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EhkWjQSkGJhg2yUjH2WMgQUjHYAf4Q5oMVfVRqChzuU=; b=X4AsilFhiIZL bUIsYLWTSuZPFFidUkrRsufHyjUBbFzFY7zjPfvxREBT8FvSaMhOwK6pg9GL22wH bqh68UV9ss7EwS99LUj7k4ysuP5amfg2nO2tsyRj9xpsUdhS4C2rqUrHx4FAtCzh Bn3gHkVfVEI2HaUAPUSN7KFf0liQxIM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EhkWjQSkGJhg2yUjH2WMgQUjHYAf4Q5oMVfVRqChz uU=; b=EY44rum/tOQ8Syzmrp5A2RdwHD8lNAceOAg3RSyeoy9CS6fG9g4YkvJZ+ 2A+CVm3pEiMRQcW3EcIcSvVfe+0qY7uvAp8+F1kGFotDsw7NQW+GtS/ddHc0JUYO 4OEcEF0IIldTRZ0GOe/PstkVfmGhlyvQAf+QRplMjiFLqRhmflg+6dJxF+KWRM2r Ce1aQHhHUy5ZgVCsFFt2AhXdj1zYtLBiAVal8dfpQ4i7vlqpU2LOzQTE2iYALUME kIT3im4iU+0PubQbQoyz6IxW52IeR60UXLTnqvZIpnUvec4iY7PlcG6pqDDL9ehc M9aaLc/2aO50sHMkv0vQv3P0rnveA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehvddgudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeen ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth enucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C7311306005C; Thu, 21 Nov 2019 17:01:24 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko Cc: Ferruh Yigit , Pavan Nikhilesh , Neil Horman , John McNamara , Marko Kovacevic , dev@dpdk.org Date: Thu, 21 Nov 2019 23:01:23 +0100 Message-ID: <3628380.zSPWDRPf13@xps> In-Reply-To: <1574165536-2586-3-git-send-email-arybchenko@solarflare.com> References: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> <1574165536-2586-1-git-send-email-arybchenko@solarflare.com> <1574165536-2586-3-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/11/2019 13:12, Andrew Rybchenko: > The deprecation notice is required since it adds more requirements > when RTE flow mark and flag actions may be used and require > changes in applications. I am still not sure what is the best solution here. I continued to think about it in this thread: http://mails.dpdk.org/archives/dev/2019-November/151960.html I think we cannot require any application change until 20.11 in order to keep API (and behaviour) compatibility. If something would be implemented in 20.02, it must be a new and optional API. That's why I think no deprecation notice is required. [...] > +* ethdev: New offload flag ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 20.02. > + This will provide application an information if ``RTE_FLOW_ACTION_TYPE_MARK`` > + or ``RTE_FLOW_ACTION_TYPE_FLAG`` is supported and, what is more important, > + allow an application to let PMD know that it would like to use these > + features. > + PMD may use the information to choose optimal datapath implementation and > + configure HW appropriately to optimize performance and/or resources usage.