From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CABE7C76188 for ; Mon, 22 Jul 2019 15:06:14 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5BE052190F for ; Mon, 22 Jul 2019 15:06:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="lIkKWHSt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="xsAd5ji+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BE052190F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BF581BEC5; Mon, 22 Jul 2019 17:06:13 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id E22B21BEC2 for ; Mon, 22 Jul 2019 17:06:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id BE7FC559; Mon, 22 Jul 2019 11:06:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Jul 2019 11:06:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Yu5a0+sDMIhou0TJw8xKG9CZbnqF634e4nrZMHQ5EKI=; b=lIkKWHSta23R Ncec4YUX+ajFEqwb432HBz/sgughSEOVkY/A+YrryyQLIzhMDLIIIFWigBEkVq1H WIpM9hBbaRO6JQLWXX7U4dIa03is43S3tOo7jB3s7bGsqpxozQJwMyt4fAQAiv0i h6fKv6mqs1fOi67QPJHs/fUwbKqses8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Yu5a0+sDMIhou0TJw8xKG9CZbnqF634e4nrZMHQ5E KI=; b=xsAd5ji+HVsFY8u7ofgXJ6VHsPWeyqhOlvKS+XAiI/pDPAqE+419vh73p c9J09L5ruN8BJjZXZGsBXtdQheXkzhWLSfAM3Z4a2OOASfEKUlCMNFlJFTm7Ei+S iiHyFiO3hdSn8mR8de2sjM56hqcr+n1zETmHEtvQc6kzmmD+dyvpcSQUyeHVvaEd ATzolRKGqvb4rvaIogBvDP/eKZU7qTrdV799qGx3zW6PZ0UiEbUgjsBYdQ+Rlsck xV6yHWhmy45YQl1GopNtlXkcU4zQWq9V6NT2N5warHwxqJJBUBPmXhAY9tqK68bR 6nYf3bGWMfV2kKVPyJmm2/xVn3w5A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeeggdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 126D8380085; Mon, 22 Jul 2019 11:06:08 -0400 (EDT) From: Thomas Monjalon To: Ajit Khaparde , Lance Richardson Cc: Ferruh Yigit , dev@dpdk.org, Somnath Kotur Date: Mon, 22 Jul 2019 17:06:06 +0200 Message-ID: <3634179.vNFH5eg47m@xps> In-Reply-To: References: <20190718033616.37605-1-ajit.khaparde@broadcom.com> <20190718033616.37605-10-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/07/2019 16:57, Ferruh Yigit: > On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > > From: Lance Richardson > > --- a/config/common_base > > +++ b/config/common_base > > @@ -212,6 +212,7 @@ CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=n > > # Compile burst-oriented Broadcom BNXT PMD driver > > # > > CONFIG_RTE_LIBRTE_BNXT_PMD=y > > +CONFIG_RTE_LIBRTE_BNXT_SHARED_ASYNC_RING=n > > Normally we don't want to introduce new config time options as much as possible. > > This is what happens when patches slip in the last minute, please Ajit try to > send patches before proposal next time. > > And back to the config option, is it something have to be a compile time flag > (if so why?), can it be replaced by a devarg? I confirm it is nack. I don't see any reason not to replace it with a runtime devargs.