From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [PATCH] net/bonding: fix create bonded device test
	failure
Date: Tue, 15 Jan 2019 17:37:36 +0000
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A400D61@irsmsx110.ger.corp.intel.com>
References: <yes>
 <1546866064-11929-1-git-send-email-hari.kumarx.vemula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Vemula, Hari KumarX" <hari.kumarx.vemula@intel.com>, Chas Williams
 <3chas3@gmail.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1546866064-11929-1-git-send-email-hari.kumarx.vemula@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Vemula, Hari KumarX
> Sent: Monday, January 7, 2019 1:01 PM
>=20
>=20
> Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>=20
> -	memcpy(&dev_info->rx_desc_lim, &internals->rx_desc_lim,
> -	       sizeof(dev_info->rx_desc_lim));
> -	memcpy(&dev_info->tx_desc_lim, &internals->tx_desc_lim,
> -	       sizeof(dev_info->tx_desc_lim));
> +	dev_info->rx_desc_lim =3D bond_lim;
> +	dev_info->tx_desc_lim =3D bond_lim;


I relooked into this, these values should be filled from salve data like th=
e way done for max_nb_rx_queues and max_nb_tx_queues
Existing code snippet:
if (slave_info.max_rx_queues < max_nb_rx_queues)
                          max_nb_rx_queues =3D slave_info.max_rx_queues;

 if (slave_info.max_tx_queues < max_nb_tx_queues)
                        max_nb_tx_queues =3D slave_info.max_tx_queues;

So, something like below you should add for rx/tx desc limit I guess.

if (slave_info.rx_desc_lim.nb_max < max_rx_desc_lim)
                                max_rx_desc_lim =3D slave_info.rx_desc_lim.=
nb_max;

if (slave_info.tx_desc_lim.nb_max < max_tx_desc_lim)
                                max_tx_desc_lim =3D slave_info.tx_desc_lim.=
nb_max;

dev_info->rx_desc_lim.nb_max =3D max_rx_desc_lim;
        dev_info->tx_desc_lim.nb_max =3D max_tx_desc_lim;

@Williams/Declan: Does this make sense?

Thanks,
Reshma