From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH] ethdev: Fix issue in Doxygen for TM API
Date: Tue, 1 May 2018 15:12:26 +0000
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BB644CF@IRSMSX108.ger.corp.intel.com>
References: <1521647133-17843-1-git-send-email-benjamin.h.shelton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Shelton, Benjamin H" <benjamin.h.shelton@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 5E20A28F3
 for <dev@dpdk.org>; Tue,  1 May 2018 17:12:30 +0200 (CEST)
In-Reply-To: <1521647133-17843-1-git-send-email-benjamin.h.shelton@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Shelton, Benjamin H
> Sent: Wednesday, March 21, 2018 3:46 PM
> To: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Shelton, Benjamin H <benjamin.h.shelton@intel.com>
> Subject: [PATCH] ethdev: Fix issue in Doxygen for TM API
>=20
> The rte_tm_node_wfq_weight_mode_update() API function operates on
> non-leaf nodes, not leaf nodes.
>=20
> Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> ---
>  lib/librte_ether/rte_tm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h
> index 2b25a87..f735f84 100644
> --- a/lib/librte_ether/rte_tm.h
> +++ b/lib/librte_ether/rte_tm.h
> @@ -1643,7 +1643,7 @@ rte_tm_node_stats_update(uint16_t port_id,
>   * @param[in] port_id
>   *   The port identifier of the Ethernet device.
>   * @param[in] node_id
> - *   Node ID. Needs to be valid leaf node ID.
> + *   Node ID. Needs to be valid non-leaf node ID.
>   * @param[in] wfq_weight_mode
>   *   WFQ weight mode for each SP priority. When NULL, it indicates that
> WFQ is
>   *   to be used for all priorities. When non-NULL, it points to a pre-al=
located
> --
> 2.6.4

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied to next-qos tree, thanks!