From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7363EC4740A for ; Mon, 9 Sep 2019 10:24:33 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 0FDB42089F for ; Mon, 9 Sep 2019 10:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FDB42089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C36B1EBD9; Mon, 9 Sep 2019 12:24:32 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 95AC51EBD8 for ; Mon, 9 Sep 2019 12:24:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 03:24:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="359446690" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga005.jf.intel.com with ESMTP; 09 Sep 2019 03:24:28 -0700 To: "Zapolski, MarcinX A" , "dev@dpdk.org" References: <20190730124950.1293-1-marcinx.a.zapolski@intel.com> <20190906131813.1343-2-marcinx.a.zapolski@intel.com> <693a2150-3c05-c2ad-bb67-f3a510f10f7e@intel.com> <51FEE37A1339864DB0A4E34597F561E30D5D50FD@HASMSX113.ger.corp.intel.com> <51FEE37A1339864DB0A4E34597F561E30D5D6AB2@HASMSX113.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Cc: Jerin Jacob , "Laatz, Kevin" Message-ID: <3a8e2412-12a0-7f18-1380-a50e5807373c@intel.com> Date: Mon, 9 Sep 2019 11:24:27 +0100 MIME-Version: 1.0 In-Reply-To: <51FEE37A1339864DB0A4E34597F561E30D5D6AB2@HASMSX113.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/2019 11:02 AM, Zapolski, MarcinX A wrote: >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, September 9, 2019 12:00 PM >> To: Zapolski, MarcinX A ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev >> structures from public API >> >> On 9/9/2019 9:07 AM, Zapolski, MarcinX A wrote: >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Friday, September 6, 2019 4:38 PM >>>> To: Zapolski, MarcinX A ; dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev >>>> structures from public API >>>> >>>> On 9/6/2019 2:18 PM, Marcin Zapolski wrote: >>>>> Split rte_eth_dev structure to two parts: head that is available for >>>>> user applications, and rest which is DPDK internal. >>>>> Make an array of pointers to rte_eth_dev structures available for >>>>> user applications. >>>>> >>>>> Signed-off-by: Marcin Zapolski >>>> >>>> <...> >>>> >>>>> diff --git a/lib/librte_bitratestats/rte_bitrate.c >>>>> b/lib/librte_bitratestats/rte_bitrate.c >>>>> index 639e47547..82d469514 100644 >>>>> --- a/lib/librte_bitratestats/rte_bitrate.c >>>>> +++ b/lib/librte_bitratestats/rte_bitrate.c >>>>> @@ -3,7 +3,7 @@ >>>>> */ >>>>> >>>>> #include >>>>> -#include >>>>> +#include >>>> >>>> This is in the library, not sure if libraries should include the >>>> header file for the drivers, can you please explain why this change is >> needed? >>>> >>> It is needed to make rte_eth_dev structure available. But yes, I agree that >> it will be more appropriate to include rte_ethdev.h and rte_ethdev_core.h >> separately. I probably wanted less includes, silly me. >>>> <...> >>>> >>>>> @@ -6,6 +6,7 @@ >>>>> #define _RTE_ETHDEV_PROFILE_H_ >>>>> >>>>> #include "rte_ethdev.h" >>>>> +#include "rte_ethdev_core.h" >>>>> >>>>> /** >>>>> * Initialization of the Ethernet device profiling. >>>>> diff --git a/lib/librte_ethdev/rte_ethdev.c >>>>> b/lib/librte_ethdev/rte_ethdev.c index 17d183e1f..5c6cc640a 100644 >>>>> --- a/lib/librte_ethdev/rte_ethdev.c >>>>> +++ b/lib/librte_ethdev/rte_ethdev.c >>>>> @@ -40,6 +40,7 @@ >>>>> >>>>> #include "rte_ether.h" >>>>> #include "rte_ethdev.h" >>>>> +#include "rte_ethdev_core.h" >>>>> #include "rte_ethdev_driver.h" >>>>> #include "ethdev_profile.h" >>>>> #include "ethdev_private.h" >>>> >>>> I was hoping "rte_ethdev_core.h" can be removed completely by >>>> distributing its content to "ethdev_private.h", "rte_ethdev_driver.h" >>>> and perhaps even to "rte_ethdev.h". >>>> >>>> Can you please explain what prevents removing "rte_ethdev_core.h"? >>> I could rename it to rte_ethdev_private. There is just rte_eth_dev and >> rte_eth_dev_data left in it. >>> >> >> I think drivers access to both 'rte_eth_dev' and 'rte_eth_dev_data' so can't >> move them to 'ethdev_private.h' why not move it to 'rte_ethdev_driver.h'? > > Because the libraries use them as well. > These are 'librte_ethdev' library internal data, I think other libraries shouldn't access them directly. As far as I can see, librte_eventdev => rte_eth_dev_data librte_eventdev => rte_eth_dev librte_telemetry => rte_eth_dev Can you see any other library accessing 'rte_eth_dev' and 'rte_eth_dev_data' ? I am not sure about 'eventdev', specially because of the Rx/Tx adapters of it, perhaps they can include the "rte_ethdev_driver.h", cc'ed Jerin. I didn't check the telemetry code, but I assume it can be fixed too, but for now "rte_ethdev_driver.h" can be included to highlight something is wrong there. And related "ethdev_private.h", as far as I understand it is not private to all libraries, it is private to the ethdev library, which means only should be used to share the definitions withing ethdev library .c files. So no other library should include it.