From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D92C6FA82 for ; Fri, 23 Sep 2022 09:31:55 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02A3042B85; Fri, 23 Sep 2022 11:31:55 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 37F4142B83; Fri, 23 Sep 2022 11:31:53 +0200 (CEST) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MYmy41Qp4zMpZq; Fri, 23 Sep 2022 17:27:08 +0800 (CST) Received: from dggpemm500015.china.huawei.com (7.185.36.181) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 17:31:51 +0800 Received: from dggpemm500008.china.huawei.com (7.185.36.136) by dggpemm500015.china.huawei.com (7.185.36.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 17:31:51 +0800 Received: from dggpemm500008.china.huawei.com ([7.185.36.136]) by dggpemm500008.china.huawei.com ([7.185.36.136]) with mapi id 15.01.2375.031; Fri, 23 Sep 2022 17:31:51 +0800 From: wangyunjian To: "dev@dpdk.org" CC: "matan@nvidia.com" , "rasland@nvidia.com" , "viacheslavo@nvidia.com" , "dkozlyuk@nvidia.com" , Huangshaozhang , "stable@dpdk.org" Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action Thread-Topic: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action Thread-Index: AQHYtrwEpdIfc1hTyUCiPjEyb4FJf63s8SEw Date: Fri, 23 Sep 2022 09:31:51 +0000 Message-ID: <429c86ba3b944c99a4b50978d456e781@huawei.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.242.157] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Friendly ping. > -----Original Message----- > From: wangyunjian > Sent: Tuesday, August 23, 2022 2:46 PM > To: dev@dpdk.org > Cc: matan@nvidia.com; rasland@nvidia.com; viacheslavo@nvidia.com; > dkozlyuk@nvidia.com; Huangshaozhang ; > wangyunjian ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when relea= sing a > drop action >=20 > Currently, the resources for hrxq->action are allocated in > mlx5_devx_hrxq_new(). But it was not being freed when the drop action was > released in mlx5_devx_drop_action_destroy(). > So, fix is to free the resources in mlx5_devx_tir_destroy(). >=20 > Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/net/mlx5/mlx5_devx.c | 7 +++++++ drivers/net/mlx5/mlx5_rxq.c | > 6 ------ > 2 files changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c = index > 6886ae1f22..09c8856f05 100644 > --- a/drivers/net/mlx5/mlx5_devx.c > +++ b/drivers/net/mlx5/mlx5_devx.c > @@ -907,6 +907,13 @@ mlx5_devx_hrxq_new(struct rte_eth_dev *dev, > struct mlx5_hrxq *hrxq, static void mlx5_devx_tir_destroy(struct > mlx5_hrxq *hrxq) { > +#if defined(HAVE_IBV_FLOW_DV_SUPPORT) > || !defined(HAVE_INFINIBAND_VERBS_H) > + if (hrxq->hws_flags) > + mlx5dr_action_destroy(hrxq->action); > + else > + mlx5_flow_os_destroy_flow_action(hrxq->action); > + hrxq->action =3D NULL; > +#endif > claim_zero(mlx5_devx_cmd_destroy(hrxq->tir)); > } >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c in= dex > eaf23d0df4..e518fe9bfd 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -2861,12 +2861,6 @@ __mlx5_hrxq_remove(struct rte_eth_dev *dev, > struct mlx5_hrxq *hrxq) { > struct mlx5_priv *priv =3D dev->data->dev_private; >=20 > -#ifdef HAVE_IBV_FLOW_DV_SUPPORT > - if (hrxq->hws_flags) > - mlx5dr_action_destroy(hrxq->action); > - else > - mlx5_glue->destroy_flow_action(hrxq->action); > -#endif > priv->obj_ops.hrxq_destroy(hrxq); > if (!hrxq->standalone) { > mlx5_ind_table_obj_release(dev, hrxq->ind_table, > -- > 2.27.0