From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852E5C76186 for ; Thu, 18 Jul 2019 02:52:32 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1EA8120873 for ; Thu, 18 Jul 2019 02:52:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA8120873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0777326C; Thu, 18 Jul 2019 04:52:29 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 97B1A2BA8; Thu, 18 Jul 2019 04:52:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 19:52:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="168138715" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 17 Jul 2019 19:52:25 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 19:52:25 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 10:52:22 +0800 From: "Wang, Ying A" To: "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 1/3] net/ice: fix flow get inputset check Thread-Index: AQHVPQuXZtQ180aqIUe0ZBztuFY8rqbPIiOAgACGVeD//31zgIAAhxgQ Date: Thu, 18 Jul 2019 02:52:22 +0000 Message-ID: <44DE8E8A53B4014CA1985CEE86C07F2A0B96289F@SHSMSX101.ccr.corp.intel.com> References: <1563413923-404004-1-git-send-email-ying.a.wang@intel.com> <1563413923-404004-2-git-send-email-ying.a.wang@intel.com> <44DE8E8A53B4014CA1985CEE86C07F2A0B962863@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDM1NDBiOTQtZTgxOC00MmQ5LWE4ODEtOWNkNTAwYjY1NGUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSlwvMmNcL0V4YUR1d1dVQURxN1pPRTdGMWxpdHFJaGdveHVLYlwvMzdsRVVDOCt2T0ZxSHJLRWFna05UUTNrempYRiJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] net/ice: fix flow get inputset check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, Qiming > Sent: Thursday, July 18, 2019 10:47 AM > To: Wang, Ying A ; Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check >=20 > So I think the bug is the skipped pattern don't pass to the next function= . Yes, this is another solution. But maybe, this solution will change more co= des.=20 Anyway, if you think this is the better solution, I will modify it. >=20 > -----Original Message----- > From: Wang, Ying A > Sent: Thursday, July 18, 2019 10:40 AM > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check >=20 >=20 >=20 > > -----Original Message----- > > From: Yang, Qiming > > Sent: Thursday, July 18, 2019 10:33 AM > > To: Wang, Ying A ; Zhang, Qi Z > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check > > > > It's no need to add RTE_FLOW_ITEM_TYPE_VOID because we have skipped > > all the VOID items. >=20 > But actually, we passed the original pattern to this function, not the on= e skipped > all the VOID items. >=20 >=20 > > > > -----Original Message----- > > From: Wang, Ying A > > Sent: Thursday, July 18, 2019 9:39 AM > > To: Zhang, Qi Z > > Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A > > ; stable@dpdk.org > > Subject: [PATCH 1/3] net/ice: fix flow get inputset check > > > > ice_get_flow_field should not set error if item->type is > > RTE_FLOW_ITEM_TYPE_VOID. > > This patch fixes this issue. > > > > Fixes: d76116a4678f ("net/ice: add generic flow API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wang Ying A > > --- > > drivers/net/ice/ice_generic_flow.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ice/ice_generic_flow.c > > b/drivers/net/ice/ice_generic_flow.c > > index c2931a1..464f6ec 100644 > > --- a/drivers/net/ice/ice_generic_flow.c > > +++ b/drivers/net/ice/ice_generic_flow.c > > @@ -465,7 +465,7 @@ static uint64_t ice_get_flow_field(const struct > > rte_flow_item pattern[], > > case RTE_FLOW_ITEM_TYPE_NVGRE: > > nvgre_spec =3D item->spec; > > nvgre_mask =3D item->mask; > > - /* Check if VXLAN item is used to describe protocol. > > + /* Check if NVGRE item is used to describe protocol. > > * If yes, both spec and mask should be NULL. > > * If no, both spec and mask shouldn't be NULL. > > */ > > @@ -480,6 +480,8 @@ static uint64_t ice_get_flow_field(const struct > > rte_flow_item pattern[], > > is_tunnel =3D 1; > > > > break; > > + case RTE_FLOW_ITEM_TYPE_VOID: > > + break; > > default: > > rte_flow_error_set(error, EINVAL, > > RTE_FLOW_ERROR_TYPE_ITEM, > > -- > > 1.8.3.1