From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A3FC433DF for ; Tue, 16 Jun 2020 12:31:38 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 074AA20734 for ; Tue, 16 Jun 2020 12:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="m4zT5FAz"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TT5yRmEo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 074AA20734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 193741BF6C; Tue, 16 Jun 2020 14:31:37 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 0E55F1BF46 for ; Tue, 16 Jun 2020 14:31:36 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 4D30E58022D; Tue, 16 Jun 2020 08:31:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 08:31:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hfygDfHCOU8OAiPh2pPT3EczroZIj1kVmn+q9NrX8U8=; b=m4zT5FAzyw37K31q ipSuYlthncd7tOa2osrjzCpUE4BkZGCeolRD2sDb9gISA0IWhMkddHmZ/+u13JJ6 YHXNkICbqTixGmFvhsgdc9H1viu2O/qskTsFMer5Ly6XyoTqfM9Q68FKKx/WN3yf zd6pAoTLncEtmBkKqPqQkLmluzssOT19/Ic9O+x+yhOkDmTcj7M5JwljS8mimG5q oM96FsuH1dN+ngkDxy2KH3VuscRHE2PGdp0wZLUBuaLdk+o+RMrlgXQ6GGa0HH7h sQ7PBkDpQU/O3aqEsW8n/VYh7rRJHivmYY9Pd20fQfyXH3MqiJ3qYbQ30+g8iS/u U13MEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hfygDfHCOU8OAiPh2pPT3EczroZIj1kVmn+q9NrX8 U8=; b=TT5yRmEoqC9pnBfoUQshkrb/sqv7Iu0C4t6/jLQ4uPBowz+Zc9YTJCg2Y mwgsdXtQqqOQA9tknwsygnsXgoLfY8uTa33ntXxc9DeCO/b5nxqQ8/+VM6bmI0uU z5OAZVMSUfSwNboEj/mswwjfc9tjLfHj/xCrZy50GceoZyUPlGt/PNXKU8Ze+IQS jjglRb6aourfsFENS1QL0CJoORt5VwiGLh09BxNJxcqff+l0M3TZTIaXkrg2SOQG ywaWTCl0CtwiL04fDpxnPlGRV7ejLBS8nq2HeVvaX6wVKngjzhnVB1SJc6pVctUn jxpczvh9nL1tagmYX/J/vHZum23iQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjedvtefgvdetffehuedvvdevkedtheejuedutddvudejveetueff geffieeftddvnecuffhomhgrihhnpehhuhgrrhhmrdgtohhmnecukfhppeejjedrudefge drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B01033280064; Tue, 16 Jun 2020 08:31:30 -0400 (EDT) From: Thomas Monjalon To: Joyce Kong Cc: stephen@networkplumber.org, david.marchand@redhat.com, mb@smartsharesystems.com, jerinj@marvell.com, bruce.richardson@intel.com, ravi1.kumar@amd.com, rmody@marvell.com, shshaikh@marvell.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com, phil.yang@arm.com, nd@arm.com, dev@dpdk.org Date: Tue, 16 Jun 2020 14:31:29 +0200 Message-ID: <4726158.WGtRM1NEbC@thomas> In-Reply-To: <20200427075856.12098-7-joyce.kong@arm.com> References: <20200427075856.12098-1-joyce.kong@arm.com> <20200427075856.12098-7-joyce.kong@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 6/6] net/hinic: use common rte bit operation APIs instead X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/04/2020 09:58, Joyce Kong: > Remove its own bit operation APIs and use the common one, > this can reduce the code duplication largely. > > Signed-off-by: Joyce Kong > Reviewed-by: Gavin Hu > --- > --- a/drivers/net/hinic/Makefile > +++ b/drivers/net/hinic/Makefile > +CFLAGS += -DALLOW_EXPERIMENTAL_API [...] > --- a/drivers/net/hinic/meson.build > +++ b/drivers/net/hinic/meson.build > +allow_experimental_apis = true Not needed in DPDK 20.08. I will remove it while merging.