From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dai, Wei" <wei.dai@intel.com>
Subject: Re: [PATCH v7 0/2] app/testpmd: add new commands to test
 new Tx/Rx offloads
Date: Tue, 8 May 2018 13:30:10 +0000
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66CF7EFE6@PGSMSX111.gar.corp.intel.com>
References: <20180322080025.30830-1-wei.dai@intel.com>
 <20180403085735.3090-1-wei.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7E2E66CC5
 for <dev@dpdk.org>; Tue,  8 May 2018 15:30:15 +0200 (CEST)
In-Reply-To: <20180403085735.3090-1-wei.dai@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh

Thanks for your feedback.
I lost your mail but I can found it in http://dpdk.org/ml/archives/dev/2018=
-April/096900.html
I will update new version of this patch for new offload API in my v8 big pa=
tch for ethdev: check offloads.
As my command to get offload capablites and configuration return all result=
s on port level and all queues,
I'd like to adopt your suggestion to use 'show port ...'
I search '.help_str' in app/test-pmd/cmdline.c and find all existed 'port c=
onfig ...' is for port level configuration.
So if it is used to add new commands to enable/disable per-queue offloading=
,  the style will be broken.
I'd like to use 'port config <port_id> <offload> on|off ' to enable/disable=
 offloading on all queues.
I also would like to use 'port <port_id> rxq|txq <queue_id> <offload> on|of=
f' to enable/disable offloading on a queue.
All above my plan want to keep the style of current command and avoid to in=
troduce more commands.
Can you agree it ?

Thanks & Best Regards
-Wei

> -----Original Message-----
> From: Dai, Wei
> Sent: Tuesday, April 3, 2018 4:58 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH v7 0/2] app/testpmd: add new commands to test new Tx/Rx
> offloads
>=20
> Existed testpmd commands can't support per queue offload configuration.
> And there are different commands to enable or disable different offloadin=
g.
> This patch set add following commands to support new Tx/Rx offloading API
> test.
>=20
> To get Rx offload capability of a port, please run:
> testpmd > rx_offload get capability <port_id>
>=20
> To get current Rx offload per queue and per port configuration of a port,
> run:
> tesstpmd > rx_offload get configuration <port_id>
>=20
> To enable or disable a Rx per port offloading, please run:
> testpmd > rx_offload enable|disable per_port vlan_strip|ipv4_cksum|...
> <port_id>
> This command will set|clear the associated bit in
> dev->dev_conf.rxmode.offloads
> for rte_eth_dev_configure and tx_conf->offloads of all Rx queues for
> rte_eth_rx_queue_setup( ).
>=20
> To enable or disable a Tx per port offloading, please run:
> testpmd > rx_offload enable|disable per_queue vlan_strip|ipv4_cksum|...
> <port_id> <queue_id>
>=20
> Same commands like "tx_offload ..." are also added to support new Tx
> offload API test.
>=20
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>=20
> ---
> v7:
>    update testpmd document
> v6:
>    reconfig port and queues if offloading is enabled or disabled
> v5:
>    don't depend on enum types defined in rte_ethdev.
> v4:
>    improve testpmd command per port offload to set or clear the port
> configuration
>    and the queue configuration of all queues.
> v3:
>    add enum rte_eth_rx_offload_type and enum rte_eth_tx_offload_type
>    free memory of port->rx_offloads and port->tx_offloads when testpmd
> is existed
> v2:
>    use rte_eth_dev_rx_offload_name() and
> rte_eth_dev_tx_offload_name().
>    remove static const strings of Rx/Tx offload names.
>=20
>=20
> Wei Dai (2):
>   app/testpmd: add commands to test new Rx offload API
>   app/testpmd: add commands to test new Tx offload API
>=20
>  app/test-pmd/cmdline.c                      | 759
> ++++++++++++++++++++++++++++
>  app/test-pmd/testpmd.c                      |  34 +-
>  app/test-pmd/testpmd.h                      |   2 +
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  87 ++++
>  4 files changed, 878 insertions(+), 4 deletions(-)
>=20
> --
> 2.9.5