From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E186C34021 for ; Mon, 17 Feb 2020 16:18:01 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B9BB22072C for ; Mon, 17 Feb 2020 16:18:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9BB22072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E5641DAA7; Mon, 17 Feb 2020 17:17:59 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5AC591DAA0; Mon, 17 Feb 2020 17:17:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 08:17:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,453,1574150400"; d="scan'208";a="229237210" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.20]) ([10.237.221.20]) by fmsmga008.fm.intel.com with ESMTP; 17 Feb 2020 08:17:54 -0800 To: Harman Kalra Cc: Jerin Jacob , Vamsi Attunuru , dev@dpdk.org, stable@dpdk.org References: <1581755704-15546-1-git-send-email-hkalra@marvell.com> <194bbbb5-7af3-2bb8-ef0b-e2a571a58efe@intel.com> <20200217143437.GA23753@outlook.office365.com> <842f21a6-8043-0608-0428-98ca07930cbf@intel.com> <20200217150648.GB23753@outlook.office365.com> <7d55c814-0a93-055b-dda6-c18041ec8d1a@intel.com> <20200217153027.GA110928@outlook.office365.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <52b53dc5-8f2a-f635-0fe1-76386d9459b7@intel.com> Date: Mon, 17 Feb 2020 16:17:53 +0000 MIME-Version: 1.0 In-Reply-To: <20200217153027.GA110928@outlook.office365.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/17/2020 3:30 PM, Harman Kalra wrote: > On Mon, Feb 17, 2020 at 03:19:53PM +0000, Ferruh Yigit wrote: >> On 2/17/2020 3:06 PM, Harman Kalra wrote: >>> On Mon, Feb 17, 2020 at 02:54:13PM +0000, Ferruh Yigit wrote: >>>> On 2/17/2020 2:35 PM, Harman Kalra wrote: >>>>> On Mon, Feb 17, 2020 at 01:21:13PM +0000, Ferruh Yigit wrote: >>>>>> External Email >>>>>> >>>>>> ---------------------------------------------------------------------- >>>>>> On 2/15/2020 8:35 AM, Harman Kalra wrote: >>>>>>> PTP functionality has been broken after a change in kernel >>>>>>> where enum npc_kpu_lc_ltype is change to allow adjustment of >>>>>>> LTYPE_MASK to detect all types of IP headers. >>>>>>> Syncing the required changes in DPDK to fix the issue. >>>>>> >>>>>> Hi Harman, >>>>>> >>>>>> Can you please provide references for, >>>>>> - What is the kernel commit causing the mentioned change? >>>>>> - After this change which version of the kernel supported by the PMD? >>>>> >>>>> Hi Ferruh >>>>> The kernel change I was refering to was in our internel kernel repo >>>>> and those kernel changes have not been upstreamed yet. Currently its part >>>>> of our marvell SDK version SDK-10.3.1.x. >>>> >>>> Got it, what is the dependency of the PMD to the Linux kernel? And does the PMD >>>> works with upstream kernels? >>> >>> Yes, for basic functionality PMD works fine with upstreamed kernel but for >>> supporting some advanced features like PTP, kernel changes are yet to be >>> upstreamed. Our kernel driver for octeontx2 PMD: >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_torvalds_linux_tree_master_drivers_net_ethernet_marvell_octeontx2_af&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj7V-7JdkxT_Z_SU6RrS37ys4UXudBQ_rrS5LRo&m=pXArrQOu5hyDcQfkwc34h1CkBsAQuEnZDcanbaM-GCQ&s=c7WM8a2aLkuXH5P5HpQofM1nmCAXufFYva5YVyEiYcM&e= >>> Kernel upstreaming activity is not in same pace as DPDK. >> >> Is the marvell SDK code in a public repo? If so can you provide the details of >> the kernel changes in that repo? It is good to have some reference on the matter. > > Marvel SDK is not in any public repo. But for reference internal kernel viz part of > SDK version SDK-10.3.1.x with commit id "08705a860e2d3aebce44d6c357ed1c0ae71d3fd9" > onwards will have the required changes. If it is not public, the commit id won't help much. Would you be OK if I add something like following while merging: The kernel side changes are exists in marvell SDK version SDK-10.3.1.x. >> >>> >>> Thanks >>> Harman >>>> >>>>> >>>>> Thanks >>>>> Harman >>>>> >>>>>> >>>>>>> >>>>>>> Fixes: b5dc3140448e ("net/octeontx2: support base PTP") >>>>>>> Cc: stable@dpdk.org >>>>>>> >>>>>>> Signed-off-by: Harman Kalra >>>>>>> --- >>>>>>> drivers/common/octeontx2/hw/otx2_npc.h | 4 ++-- >>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/common/octeontx2/hw/otx2_npc.h b/drivers/common/octeontx2/hw/otx2_npc.h >>>>>>> index a0536e0ae..3dfc137a3 100644 >>>>>>> --- a/drivers/common/octeontx2/hw/otx2_npc.h >>>>>>> +++ b/drivers/common/octeontx2/hw/otx2_npc.h >>>>>>> @@ -201,7 +201,8 @@ enum npc_kpu_lb_ltype { >>>>>>> }; >>>>>>> >>>>>>> enum npc_kpu_lc_ltype { >>>>>>> - NPC_LT_LC_IP = 1, >>>>>>> + NPC_LT_LC_PTP = 1, >>>>>>> + NPC_LT_LC_IP, >>>>>>> NPC_LT_LC_IP_OPT, >>>>>>> NPC_LT_LC_IP6, >>>>>>> NPC_LT_LC_IP6_EXT, >>>>>>> @@ -209,7 +210,6 @@ enum npc_kpu_lc_ltype { >>>>>>> NPC_LT_LC_RARP, >>>>>>> NPC_LT_LC_MPLS, >>>>>>> NPC_LT_LC_NSH, >>>>>>> - NPC_LT_LC_PTP, >>>>>>> NPC_LT_LC_FCOE, >>>>>>> }; >>>>>>> >>>>>>> >>>>>> >>>> >>