From: Ferruh Yigit <ferruh.yigit@intel.com> To: Alfredo Cardigliano <cardigliano@ntop.org> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 08/17] net/ionic: add adminq support Date: Mon, 2 Dec 2019 16:15:58 +0000 Message-ID: <56092d48-d19f-d07b-c152-e5ee1f1d45a6@intel.com> (raw) In-Reply-To: <20191015082235.28639-9-cardigliano@ntop.org> On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add support for the admin queue, which is used for most > of the NIC configurations. > > Signed-off-by: Alfredo Cardigliano <cardigliano@ntop.org> > Reviewed-by: Shannon Nelson <snelson@pensando.io> <...> > +int > +ionic_cq_init(struct ionic_lif *lif, struct ionic_cq *cq, > + struct ionic_intr_info *intr, > + uint32_t num_descs, size_t desc_size) > +{ > + if (desc_size == 0) { > + ionic_init_print(ERR, "Descriptor size is %lu", desc_size); The 32 bits build is failing [1], there are multiple similar error caused by the format identifiers in the logs, can you please check it? [1] error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t’ {aka ‘unsigned int’} [-Werror=format=]
next prev parent reply index Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 8:22 [dpdk-dev] [PATCH v2 00/17] Introduces net/ionic PMD Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 01/17] net/ionic: add skeleton Alfredo Cardigliano 2019-12-02 16:06 ` Ferruh Yigit 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 02/17] net/ionic: add hardware structures definitions Alfredo Cardigliano 2019-12-02 16:07 ` Ferruh Yigit 2019-12-02 16:33 ` Stephen Hemminger 2019-12-04 16:26 ` Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 03/17] net/ionic: add log Alfredo Cardigliano 2019-12-02 16:07 ` Ferruh Yigit 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 04/17] net/ionic: register and initialize the adapter Alfredo Cardigliano 2019-12-02 16:09 ` Ferruh Yigit 2019-12-08 19:25 ` Alfredo Cardigliano 2019-12-09 9:12 ` Ferruh Yigit 2019-12-02 16:35 ` Stephen Hemminger 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 05/17] net/ionic: add port management commands Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 06/17] net/ionic: add basic lif support Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 07/17] net/ionic: add doorbells Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 08/17] net/ionic: add adminq support Alfredo Cardigliano 2019-12-02 16:15 ` Ferruh Yigit [this message] 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 09/17] net/ionic: add notifyq support Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 10/17] net/ionic: add basic port operations Alfredo Cardigliano 2019-12-02 16:11 ` Ferruh Yigit 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 11/17] net/ionic: add RX filters support Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 12/17] net/ionic: add Flow Control support Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 13/17] net/ionic: add RX and TX handling Alfredo Cardigliano 2019-12-02 16:13 ` Ferruh Yigit 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 14/17] net/ionic: add RSS support Alfredo Cardigliano 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 15/17] net/ionic: add stats Alfredo Cardigliano 2019-12-02 16:14 ` Ferruh Yigit 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 16/17] net/ionic: add TX checksum support Alfredo Cardigliano 2019-12-02 16:15 ` Ferruh Yigit 2019-10-15 8:22 ` [dpdk-dev] [PATCH v2 17/17] net/ionic: read fw version Alfredo Cardigliano 2019-10-15 13:09 ` [dpdk-dev] [PATCH v2 00/17] Introduces net/ionic PMD Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56092d48-d19f-d07b-c152-e5ee1f1d45a6@intel.com \ --to=ferruh.yigit@intel.com \ --cc=cardigliano@ntop.org \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git