From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC64C04AB5 for ; Thu, 6 Jun 2019 08:39:16 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 7A0F7207E0 for ; Thu, 6 Jun 2019 08:39:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="eRfPcuzW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A0F7207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 41D301B95A; Thu, 6 Jun 2019 10:39:14 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1161A1B958 for ; Thu, 6 Jun 2019 10:39:12 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190606083911euoutp011aad306918056ced6be4ca574cfa1d6c~lj0A626LV2320323203euoutp01B for ; Thu, 6 Jun 2019 08:39:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190606083911euoutp011aad306918056ced6be4ca574cfa1d6c~lj0A626LV2320323203euoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1559810352; bh=IdC4/mTRGy076Lcwum4fPnpgWki5VYpOwIa5ay0vKxQ=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=eRfPcuzWAzNucyIim/lkDVxQz3LY1T5C2m1AU2bercNW+UWtoM3/UH7egFWLJ0nSa o52353kb4uN28w+sFoPuP5/rcsdKdUz1loTo+baRYGVV4oI5PckOljCIQYktXNsbpt cBLiWXL6/h7XYJDkQTffyRWvjDp1UHKdon+ipw80= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190606083911eucas1p2c90f4e529b51a08fac703de652505b44~lj0Abusga1819218192eucas1p2o; Thu, 6 Jun 2019 08:39:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A4.BA.04377.F21D8FC5; Thu, 6 Jun 2019 09:39:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190606083910eucas1p126a5b89f9b5a5cba39096d943f8343f2~ljz-pTcJo1868418684eucas1p1M; Thu, 6 Jun 2019 08:39:10 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190606083910eusmtrp2f64c796f5eaa21ddf2cc7a3a98df7d88~ljz-ZrTna2323123231eusmtrp2r; Thu, 6 Jun 2019 08:39:10 +0000 (GMT) X-AuditID: cbfec7f4-12dff70000001119-2e-5cf8d12fda9a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D2.F6.04140.E21D8FC5; Thu, 6 Jun 2019 09:39:10 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190606083909eusmtip1dfba9fa09dc8b702172d642fc3133ecf~ljz_3QTOX1612616126eusmtip1r; Thu, 6 Jun 2019 08:39:09 +0000 (GMT) To: David Marchand Cc: dev , Thomas Monjalon , Anatoly Burakov , Jan Blunck , Qi Zhang , Kevin Traynor , dpdk stable From: Ilya Maximets Message-ID: <5d819873-3934-53d4-9ce7-5170290d0445@samsung.com> Date: Thu, 6 Jun 2019 11:39:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFKsWRmVeSWpSXmKPExsWy7djPc7r6F3/EGCw8z2nx6N5iZovtK7rY LN592s5kcaX9J7tF68NWJou1hz6wW0zf0M9m8a/jD7vFpwcnWBw4PX4tWMrqsXmFlsfiPS+Z PI7dnMbu8X7fVTaPvi2rGAPYorhsUlJzMstSi/TtErgyZvxaz1Swnrtiw5/7bA2MHzi6GDk5 JARMJO5PPcHexcjFISSwglFi0f+LLBDOF0aJG1NbGSGcz4wS8w8+ZIJpObajF6plOaPEs3kT WCGcj0Ati56ygFQJC4RITHw6iRXEFhHQk5i4bRNYnFngJ6PE+c2VIDabgI7EqdVHGEFsXgE7 oA09YBtYBFQkeicfBrNFBSIkvuzcBFUjKHFy5hOwOZwCgRIvJt1khJgpLtH0ZSUrhC0v0bx1 NjPIQRICp9glJm1ayQhxtovEseXnWCBsYYlXx7ewQ9gyEv93zod6rV7ifstLRojmDkaJ6Yf+ QSXsJba8PgfUwAG0QVNi/S59iLCjRMOqC6wgYQkBPokbbwUhbuCTmLRtOjNEmFeio00IolpF 4vfB5cwQtpTEzXef2ScwKs1C8tksJN/MQvLNLIS9CxhZVjGKp5YW56anFhvlpZbrFSfmFpfm pesl5+duYgSmqNP/jn/ZwbjrT9IhRgEORiUeXomN32OEWBPLiitzDzFKcDArifCWXfgRI8Sb klhZlVqUH19UmpNafIhRmoNFSZy3muFBtJBAemJJanZqakFqEUyWiYNTqoFx7vXQFWsip6uf uTRt6/tKJoVkyWutM55eWjLRWvHvkkeMhSskOjS8eR9zd7V/j+y4Jj3n3dezaqFx3/vulW5c ONNlQbDV1E+KR4s/+5rP1lCv+VO7uou1Ki/YXWzmwudq83KWdyhe9RE1N1vcE7BEaW6VdFBx QvnWd4Ve76+kPzSImVfMO6VRiaU4I9FQi7moOBEA0PZZXE0DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t/xu7p6F3/EGJzcKmLx6N5iZovtK7rY LN592s5kcaX9J7tF68NWJou1hz6wW0zf0M9m8a/jD7vFpwcnWBw4PX4tWMrqsXmFlsfiPS+Z PI7dnMbu8X7fVTaPvi2rGAPYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV 9O1sUlJzMstSi/TtEvQyZvxaz1Swnrtiw5/7bA2MHzi6GDk5JARMJI7t6GXvYuTiEBJYyiix b9dUVoiElMSPXxegbGGJP9e62CCK3jNKPGveywySEBYIkZj4dBJYkYiAnsTEbZtYQIqYBX4y SvyYeh2q4yKTxP6OqSwgVWwCOhKnVh9hBLF5Bewk5h/sYQKxWQRUJHonHwazRQUiJGbvamCB qBGUODnzCZjNKRAo8WLSTbBeZgF1iT/zLjFD2OISTV9WskLY8hLNW2czT2AUmoWkfRaSlllI WmYhaVnAyLKKUSS1tDg3PbfYSK84Mbe4NC9dLzk/dxMjMC63Hfu5ZQdj17vgQ4wCHIxKPLwS G7/HCLEmlhVX5h5ilOBgVhLhTbz9JUaINyWxsiq1KD++qDQntfgQoynQcxOZpUST84EpI68k 3tDU0NzC0tDc2NzYzEJJnLdD4GCMkEB6YklqdmpqQWoRTB8TB6dUA6N5uUroknSenX6PdpV6 rgn8WHxiw1prr2Upan6b97Oc97hZeSc31LxfnN/0RL/35BSeiwtWCh9t3RifKNpdwRr3Yk/o E+0DD4w3fpqZuKbmyO6amVp/Ig5qFNu6h/aU/znzvvRx9kG3tbsTP+0IDJy9Xjz1bvZPNaM5 T5OvvZtUNmF556Htqw4qsRRnJBpqMRcVJwIAqTtBiOECAAA= X-CMS-MailID: 20190606083910eucas1p126a5b89f9b5a5cba39096d943f8343f2 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190530132538eucas1p28fcfddad5b73d3a0baf7095f25a6c1fd X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190530132538eucas1p28fcfddad5b73d3a0baf7095f25a6c1fd References: <20190530132526.3496-1-i.maximets@samsung.com> <4dd83792-1418-dc82-9e98-a993438faab9@samsung.com> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03.06.2019 19:13, David Marchand wrote: > > > On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets > wrote: > > On 03.06.2019 11:50, David Marchand wrote: > > > > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets >> wrote: > > > >     According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > >     'hotplug' equivalents must return 0 or negative error code. Bus code > > > > > > About this first part, existing callers in dpdk are not consistent with the api which might explain why this was not seen earlier. > > How about fixing the existing callers? > > Do you mean replacing all the 'rte_dev_probe() != 0' with 'rte_dev_probe() < 0' > around the codebase? > > > Yes. > It is not necessary to this patch so I can handle it if you don't have time. > But dpdk should show a good example by respecting its own apis description. I agree. I'll send v2 with fixed users. > The problem is in local_dev_probe() (resp. local_dev_remove()) itself, since > this internal api announces it should return < 0 on error. Hmm. I missed that private internal API defined for local_* functions. I'll move the check from rte_dev_probe() to local_dev_probe(). Best regards, Ilya Maximets.