From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] examples/vm_power: fix strcpy buffer overrun
Date: Tue, 16 Jul 2019 13:28:31 +0200 [thread overview]
Message-ID: <6012179.SWPVsCGEkT@xps> (raw)
In-Reply-To: <20190716111900.33553-1-david.hunt@intel.com>
16/07/2019 13:19, David Hunt:
> replace strcpy with strlcpy to prevent buffer overrun
> With fix, attempting to use a VERY lonng vm name results in a nicely
> truncated 32 character name rather than a segfault:
> Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd]
>
> Using strlcpy rather than rte_strlcpy, as the rte_ version is only a
> fallback.
>
> As well as the fix in main.c, this patch also changes an occurrence of
> rte_strlcpy in channel_manager.c and channel_monitor.c to strlcpy.
>
> Fixes: 59287933a0bb ("examples/vm_power: add options to guest app")
> Cc: stable@dpdk.org
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-07-16 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 14:04 [dpdk-dev] [PATCH v1] examples/vm_power: fix strcpy buffer overrun David Hunt
2019-07-12 14:14 ` Burakov, Anatoly
2019-07-12 14:47 ` Bruce Richardson
2019-07-14 13:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-07-16 8:24 ` [dpdk-dev] [PATCH v2] " David Hunt
2019-07-16 11:05 ` Thomas Monjalon
2019-07-16 11:23 ` Hunt, David
2019-07-16 11:19 ` [dpdk-dev] [PATCH v3] " David Hunt
2019-07-16 11:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6012179.SWPVsCGEkT@xps \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).