From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH 31/41] ethdev: use contiguous allocation for
 DMA memory
Date: Mon, 5 Mar 2018 12:15:53 +0300
Message-ID: <62f57c50-3e5a-7202-7a40-6d0e66c68b43@solarflare.com>
References: <cover.1520083504.git.anatoly.burakov@intel.com>
 <a43f6a900f8b9eeba981005dbb49fcc5c59778b7.1520083504.git.anatoly.burakov@intel.com>
 <405c4b97-4561-6ef7-5844-fdc0cdfaabc5@solarflare.com>
 <28a175c1-b306-ec7b-e69b-003b40968d2e@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, <keith.wiles@intel.com>,
 <jianfeng.tan@intel.com>, <andras.kovacs@ericsson.com>,
 <laszlo.vadkeri@ericsson.com>, <benjamin.walker@intel.com>,
 <bruce.richardson@intel.com>, <konstantin.ananyev@intel.com>,
 <kuralamudhan.ramakrishnan@intel.com>, <louise.m.daly@intel.com>,
 <nelio.laranjeiro@6wind.com>, <yskoh@mellanox.com>, <pepperjo@japf.ch>,
 <jerin.jacob@caviumnetworks.com>, <hemant.agrawal@nxp.com>,
 <olivier.matz@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id C44A74C7F
 for <dev@dpdk.org>; Mon,  5 Mar 2018 10:16:14 +0100 (CET)
In-Reply-To: <28a175c1-b306-ec7b-e69b-003b40968d2e@intel.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/05/2018 12:08 PM, Burakov, Anatoly wrote:
> On 03-Mar-18 2:05 PM, Andrew Rybchenko wrote:
>> On 03/03/2018 04:46 PM, Anatoly Burakov wrote:
>>> This fixes the following drivers in one go:
>>
>> Does it mean that these drivers are broken in the middle of patch set 
>> and fixed now?
>> If so, it would be good to avoid it. It breaks bisect.
>>
>
> Depends on the definition of "broken". Legacy memory mode will still 
> work for all drivers throughout the patchset. As for new memory mode, 
> yes, it will be "broken in the middle of the patchset", but due to the 
> fact that there's enormous amount of code to review between fbarray 
> changes, malloc changes, contiguous allocation changes and adding new 
> rte_memzone API's, i favored ease of code review over bisect.
>
> I can of course reorder and roll up several different patchset and all 
> driver updates into one giant patch, but do you really want to be the 
> one reviewing such a patch?

Is it possible to:
1. Introduce _contig function
2. Switch users of the contiguous allocation to it as you do now
3. Make the old function to allocate possibly non-contiguous memory